maximize_pane doesn't work if other session has a maximized window. about .tmux HOT 11 CLOSED

Hello @amosbird, thanks for the report.

Can you please try whether the fix-maximize_pane branch fixes it for you?

from .tmux.

@gpakosz I get cut -c3- ~/.tmux.conf | sh -s _maximize_pane 1 %9' returned 1 when toggling maximize_pane while there is one existing in another session.

from .tmux.

I'll give it another try tonight. Can you please tell me which version of tmux you're using? and which OS?

from .tmux.

@gpakosz I use the nearly latest tmux tmux 2.4.

from .tmux.

I confirm I can reproduce with tmux 2.4 but at that point I didn't investigate what changes between 2.3 and 2.4.

from .tmux.

I forced pushed the fix-maximize_pane branch. Can you please give it another try?

from .tmux.

It works as expected. Thanks :-) . BTW, what is the correct way to override key bindings? I'd like to do this,

bind 3 split-window -v
bind 2 split-window -h
bind 1 toggle_maximize_pane

Currently I override them directly in .tmux.conf which may not be a good choice for future upgrade.

from .tmux.

Just move that at the end of your ~/.tmux.conf.local copy, there's a dedicated section for overrides.

You will need something like the following though:

bind 1 run "cut -c3- ~/.tmux.conf | sh -s _maximize_pane #{session_name} #D"

from .tmux.

See this comment for a detailed explanation of the cut -c3- ~/.tmux.conf | sh -s thing.

from .tmux.

yeah, i know. That's why I feel a bit weird. split-window may also need options for directory settings and maybe ssh sessions. I wonder if it could be more user friendly. e.g. We could define a set of functions for overriding.

from .tmux.

Well I'll first close this PR with the fix then I'll think about further customization.

from .tmux.