Setting stdin to pipe fails.. about child_pty HOT 11 CLOSED

FYI, here is my exact line of code:

@child = ChildPTY.spawn(args[0], args.slice(1), cwd: cwd, env: env, stdio: ['pipe', 'pty', 'pty'])

from child_pty.

Atom Version: 1.12.6
Electron Version: 1.3.9
System: linux 4.8.12-2-ARCH
Thrown From: script-runner package, v2.0.0

Stack Trace

Uncaught Error: spawn /usr/bin/env EFAULT

At events.js:160

Error: spawn /usr/bin/env EFAULT
    at Object.exports._errnoException (util.js:1026:11)
    at Socket.<anonymous> (/home/samuel/.atom/packages/script-runner/node_modules/child_pty/lib/child_pty.js:108:15)
    at Socket.g (events.js:286:16)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:543:20)

from child_pty.

Thanks for this report. I'm able to reproduce this issue.

from child_pty.

Thanks looking forward to an updaye

from child_pty.

Is the exechelper really necessary? Couldn't you do most of the work in NAN_METHOD(Open) in pty.cpp?

from child_pty.

Unfortunately, yes it is neccassary. You have to call TIOCSCTTY to set the controlling pty after the new process is forked. And as forking/executing is done by node and we cannot hook anything in between fork and exec I have to use this wrapper.

Actually that's the problem why your program does not work: I foolishly assumed, that stdin is always the pty which isn't true for your case.

I'm unavailable at the weekend, so expect a fix at sunday.

from child_pty.

bump. (:

from child_pty.

463f063 fixed, please test 3.0.5

from child_pty.

Awesome :)

from child_pty.

Damn, give me a sec and wait for 3.0.6 :D

from child_pty.

done, please check and reopen if anything fails! Sorry for the long delay!

from child_pty.