Export function to get uncompressed Textures. about phoenix-shared-interface HOT 2 CLOSED

What do you think about this?

typedef void (*PxTexDecompressCallback)(uint8_t const* data, uint32_t size, void* context);
void pxTexDecompress(PxTexture const* tex, PxTexDecompressCallback cb, void* context);

This would automatically allocate the data buffer and free it after the callback exits. You'd use it like this:

void copyTexture(uint8_t const* data, uint32_t size, void* context) {
   uint8_t** output = context;
   *output = malloc(size);
   memcpy(*output, data, size);
}

int main() {
   uint8_t* data;
   pxTexDecompress(tex, copyTexture, &data);


   // Now `data` contains the decompressed image data.
   free(data);
}

from phoenix-shared-interface.

Thanks for your idea. But I would like to avoid callbacks as it adds a new architecture pattern you only use for Vm right now (where it definitely makes sense).

On C# interface I already build small wrapper functions which take care of loading, transforming, and deleting C-data. No need for callbacks.

How about using it the classical way? Something like:

PXC_API uint8_t const* pxTexGetMipmapUncompressed(PxTexture const* tex, uint32_t* length, uint32_t level, uint32_t* width, uint32_t* height) {
    ...
}

Normal flow for C# sharp is right now:

1. Get TextureMetadata - exists
2. Decide whether to call pxTexGetMipmap() or pxTexGetMipmapUncompressed() based on TextureFormat - second half is new
3. Then call pxTexMipmapUncompressedDestroy() if uncompressed data was received before. - new

from phoenix-shared-interface.