Git Product home page Git Product logo

Comments (1)

gorodnitskiy avatar gorodnitskiy commented on May 21, 2024

Thank you for bringing up this issue!

You're correct that TransformsWrapper should be set up to apply transformations for training. However, this code specified only for testing. I am using the MNIST dataset which includes separate train and test sets, and then I concatenate these sets for splitting them into new train, validation, and test sets, which required for testing of different code parts (see more in tests/). So, in this context, the exact mode of TransformsWrapper is not critical in MNISTDataModule class, as the transformations applied to the initial MNIST sets are the same (see more in configs/datamodule/mnist.yaml) due to further splitting.

I realize that this might not be clear from the code. To improve clarity, I added a comment explaining why the same transformations are used, and changed the mode name to "train". I hope it will help avoid any misunderstanding.

The main logic of DataModule in this pipeline could be seen in src/datamodules/datamodules.py. MNISTDataModule is used just for testing.

Thank you for your contribution to improving the quality and clarity of this project. If you have any further questions or suggestions, feel free to share!

from yet-another-lightning-hydra-template.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.