Cannot show diff in the current document about modific HOT 7 CLOSED

OK I just found what the problem is, it happens when the diff somehow has empty lines, probably because of the last part about properties.

Youi just need to replace occurences of "if line[0]" with "if line and line[0]"

from modific.

Thank you for the solution. I will add it to the code ASAP.

from modific.

I could not reproduce this issue, but I made fix for it as you proposed.
Let me know if plugin works now.

from modific.

Thanks, I'll let you know when I get back to office.
Though I remembver I had to change 2 occurences to fix it, and once more to completely get rid of stack traces.

If it does not fix, I'll send you a patch.
Thanks anyways.

from modific.

Tested from office, I still have a backtrace and it fails.
So here is a patch :

--- Modific.py.orig  2013-01-14 11:12:13.000000000 +0100
+++ Modific.py 2013-01-14 11:14:16.000000000 +0100
@@ -312,17 +312,17 @@
         deleted = []

         for chunk in self.get_chunks():
             current = chunk['start']
             deleted_line = None
             for line in chunk['lines']:
-                if line[0] == '-':
+                if line.startswith('-'):
                     if (not deleted_line or deleted_line not in deleted):
                         deleted.append(current)
                     deleted_line = current
-                elif line[0] == '+':
+                elif line.startswith('+'):
                     if deleted_line:
                         deleted.pop()
                         deleted_line = None
                         changed.append(current)
                     elif current - 1 in changed:
                         changed.append(current)

Sorry for not bothering to fork and do a pull request, I'm at work and lacking time + git tools...

from modific.

Thanks. I should have been using startswith instead of line[0]

from modific.

Please, feel free to reopen this issue, if it still occurs.

from modific.