Git Product home page Git Product logo

Comments (2)

ethanwater avatar ethanwater commented on July 30, 2024 1

Hey @go-slark,

Was browsing and saw your issue. Ensure that you're using a mutex for your write operations to prevent any overlap. Kind of like this:

func (s *Session) write() {
   ...
   for {
      ...
      s.writeMutex.Lock()
      select {
      case m := <-s.out:
         ...
         s.writeMutex.Unlock()
         ...
      case <-tk.C:
         ...
         s.writeMutex.Unlock()
         ...
      }
   }
}

from websocket.

yyasha avatar yyasha commented on July 30, 2024

The same problem.
When I run my code with the race flag go run -race ./main.go I get a message:

WARNING: DATA RACE
Read at 0x00c00020e078 by goroutine 7:
github.com/gorilla/websocket.(*Conn).beginMessage()
/home/yash/go/pkg/mod/github.com/gorilla/[email protected]/conn.go:492 +0x5c
github.com/gorilla/websocket.(*Conn).WriteMessage()
/home/yash/go/pkg/mod/github.com/gorilla/[email protected]/conn.go:779 +0xeb
.....

Previous write at 0x00c00020e078 by goroutine 10:
github.com/gorilla/websocket.(*messageWriter).endMessage()
/home/yash/go/pkg/mod/github.com/gorilla/[email protected]/conn.go:561 +0xba
github.com/gorilla/websocket.(*messageWriter).flushFrame()
/home/yash/go/pkg/mod/github.com/gorilla/[email protected]/conn.go:648 +0xb84
github.com/gorilla/websocket.(*messageWriter).Close()
/home/yash/go/pkg/mod/github.com/gorilla/[email protected]/conn.go:746 +0x8f
github.com/gorilla/websocket.(*Conn).WriteJSON()
/home/yash/go/pkg/mod/github.com/gorilla/[email protected]/json.go:29 +0x15e
.....

from websocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.