Comments (5)
I also ran into this problem today. When adding an empty Link element, it does not panic:
if item.Link == nil {
item.Link = &feeds.Link{}
}
However, you end up with an empty <link>
tag.
But nevertheless, this error should at least be returned by feed.ToRss()
and feed.ToAtom()
or not be generated at all.
from feeds.
Okay, didn't check it because I don't have time right now, but believe you it's ok. Closing issue now. Thank you for discussion.
from feeds.
I agree with you @Gumkle that the link
should be optional. Since there is no active development in the project you can fork the project and make the required changes. We can close this issue.
from feeds.
There is already an MR for it here: #96
from feeds.
@Gumkle please close the issue. MR is merged
from feeds.
Related Issues (20)
- [FEATURE] iTunes RSS extensions support
- Link feed field recommended, but not required for Atom and JSON feeds HOT 6
- Sort feed items by created timestamp HOT 5
- problems unmarshaling rss HOT 3
- New release? HOT 1
- Time for a new release? HOT 2
- Itunes Podcast Tags HOT 5
- Migrate to CircleCI HOT 1
- JSON Hubs are broken [bug] HOT 1
- [feature] RSS item can hold multiple <category> HOT 1
- [feature] isPermaLink="false" for guid field HOT 1
- [feature] add image/category/tags attributes HOT 2
- Spurious empty <summary> elements in atom feed HOT 12
- RSS feeds where items have author tags aren't valid HOT 3
- Support `xml:base` HOT 1
- [feature] Support JSON feed v1.1 HOT 4
- [bug] Sending deprecated Content-Type header HOT 3
- [bug] slice bounds out of range [-1:] HOT 1
- [feature] Allow multiple Links in a feed item HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feeds.