Git Product home page Git Product logo

Comments (8)

sa8ab avatar sa8ab commented on June 15, 2024 1

I made it work with Reanimated v2 and it looks quite emazing, I will pull a request for v2.

Only issue I am facing it that, when you scroll out of bottomsheet, I mean "while scrolling to bottom and finger goes out of the bottom sheet" , all the gestures disable which does not feel quite perfect in this case. You have any idea how to make it work? @gorhom

from react-native-bottom-sheet.

gorhom avatar gorhom commented on June 15, 2024 1

Great! Not sure why, but ill need to examine the gestures states

from react-native-bottom-sheet.

gorhom avatar gorhom commented on June 15, 2024

hi @sa8ab , thanks for reporting this

this is expected crash, the library was built with Reanimated v1, However migrating this library to Reanimated v2 is a plan for sure.

let me know if you want to contribute :)

from react-native-bottom-sheet.

sa8ab avatar sa8ab commented on June 15, 2024

Reanimated2 was supposed to be backward compatible with v1, if this is not the case I we almost can't have v2 installed beside the libraries that use v1!! I'm happyn't :((

from react-native-bottom-sheet.

sa8ab avatar sa8ab commented on June 15, 2024

@gorhom I converted imports from interpolate to interpolateNode and easing to EasingNode and it doesn't crash anymore, but I get the following error. can you help me with it?
image

from react-native-bottom-sheet.

gorhom avatar gorhom commented on June 15, 2024

Hi @sa8ab! Try pulling latest commits from master again ! It should work

from react-native-bottom-sheet.

sa8ab avatar sa8ab commented on June 15, 2024

Nice, let me know if you need screen recording of what is happening

from react-native-bottom-sheet.

gorhom avatar gorhom commented on June 15, 2024

You could submit a draft pr, and ill investigate it with you

from react-native-bottom-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.