Git Product home page Git Product logo

Comments (10)

Mikey1993 avatar Mikey1993 commented on August 9, 2024

This is a blessed move on my part (I am the Hebrew translator on Crowdin), and would be glad to help.

from umatrix.

gorhill avatar gorhill commented on August 9, 2024

I will use a different approach than with uBlock though, as per @Deathamns' input: using @@bidi_ makes the code non-portable. It can be avoided with a mix of simple CSS/JS.

from umatrix.

Mikey1993 avatar Mikey1993 commented on August 9, 2024

Sure thing, I agree.

from umatrix.

gorhill avatar gorhill commented on August 9, 2024

So I am going to try and fix this today. There are things I am not sure about how it should render for RTL languages, like the matrix:

a

Should the top toolbar be exactly reverse-ordered (i.e. scope selector to the right, etc.), or should I keep the exact same order?

Also, what about the matrix columns, exact same or exact reverse?

from umatrix.

Mikey1993 avatar Mikey1993 commented on August 9, 2024

The top toolbar should be reverse-ordered, e.g. the "mozilla.org" drop down list on the most right, then the power button icon, then the lock icon and so on..

While the matrix columns should be as shown in your image.
Although I see that some of the titles are cut out, is it something you are gonna address?

Thanks for your work!

from umatrix.

gorhill avatar gorhill commented on August 9, 2024

Re. "middle". This is what I have on my side when using "he" locale:

a

from umatrix.

Mikey1993 avatar Mikey1993 commented on August 9, 2024

Yes, I was silly and didn't update uMatrix to the latest version where you've applied the second patch to this issue - it looks like in your image.

BTW, I am worried about the cut off of some of the headers on the matrix, I have no shorter names or abbreviations for them...
Any thoughts about that?

from umatrix.

Mikey1993 avatar Mikey1993 commented on August 9, 2024

Actually... I think that the font that English uses is narrower than the one that is used by Hebrew.
Can we sort this out and ultimately fix the cut off?

from umatrix.

gorhill avatar gorhill commented on August 9, 2024

Difficult to solve. There is a limit on how wide a popup can be. When using the setting "Large font", the popup is very close to the limit, and we have to be sure we don't beyond this limit, or the matrix will be all broken, i.e. no longer a matrix visually.

from umatrix.

gorhill avatar gorhill commented on August 9, 2024

I will experiment with CSS transform tricks when I have time, but I won't hold from "shipping" for now.

from umatrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.