Git Product home page Git Product logo

Comments (6)

gorbin avatar gorbin commented on June 24, 2024

check it, thanks. Forgot about it in ASNETutorial app.

from asne.

tylerjroach avatar tylerjroach commented on June 24, 2024

This looks to be a bug in ASNE rather than just the tutorial. This same exception also occurs when replacing fragments in an activity. For example, say I have a home activity that can open either a login fragment or a signup fragment. If I open the signup fragment, press back, then go to the login fragment, any requestLogin() call will cause the same null pointer.

If it is any help, I've verified this behavior doesn't occur using the Android Social Networks library ASNE was based off.

from asne.

tylerjroach avatar tylerjroach commented on June 24, 2024

@ITurchenko Here is a workaround that may help for the time being. This worked for me.

Fragment fragment = getSupportFragmentManager().findFragmentByTag(SOCIAL_NETWORK_TAG);
        if(fragment != null) {
            getSupportFragmentManager().beginTransaction().remove(fragment).commit();
            getSupportFragmentManager().executePendingTransactions();
        }

On your orientation change, remove the old asne fragment and create a new one. executePendingTransactions() must be used to make sure the old one is removed before the new created.

Hope this helps.

from asne.

tylerjroach avatar tylerjroach commented on June 24, 2024

I think the issue is the way that the context is passed.

FacebookSocialNetwork fbNetwork = new FacebookSocialNetwork(this, fbScope);
        mSocialNetworkManager.addSocialNetwork(fbNetwork);

On orientation changed or a replaced fragment, the original "this" fragment context that is passed is stale.

from asne.

ultraon avatar ultraon commented on June 24, 2024

Is this bug already fixed?

from asne.

ultraon avatar ultraon commented on June 24, 2024

I found another way to avoid crash and memory leaks (use this code in your fragment):

...
private SocialNetworkManager snm;
...
@Override
    public void onResume() {
        super.onResume();
        if (null == snm || snm.getInitializedSocialNetworks().isEmpty()) initSocialManager();
    }

    @Override
    public void onPause() {
        super.onPause();
        if (isRemoving() || getActivity().isFinishing()/* or check for change rotation event*/) {
            if (null != snm && snm.isAdded()) getFragmentManager().beginTransaction().remove(snm).commit();
            snm = null;
        }
    }
...

from asne.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.