Comments (5)
You are going to laugh. I literally JUST hit this issue writing the compression filter.
Looks like I'm implementing a fix!
from quilkin.
Agreed, they should probably be something more like:
"contents" => from_utf8(packet).unwrap.or_else(|| format!("<raw bytes. len: {}>", packet.len()))
- or something like that
from quilkin.
I'm thinking it makes more sense to remove the log lines rather than work around it? Currently it seems to be unneeded work to try to parse every packet and create a log record each time only to discard it, especially since metrics tracks that info already.
from quilkin.
I honestly find it really useful when debugging issues found by integration tests, because I can see where in the flow packets are failing.
from quilkin.
I think this relates to #153 outcome in that since the log messages are only needed during development we can compile them entirely away? I'm thinking then we can log them at level trace
so that they are explicitly enabled, temporarily when needed
from quilkin.
Related Issues (20)
- proxy::sessions::tests::same_address_uses_different_sockets deadlocks HOT 3
- Move `Filter::ReadContext` to `ClusterMap`
- Redis Provider/Agent
- Benchmark error: "Resource temporarily unavailable" HOT 1
- Evaluate LTO, CGU=1, Profile-Guided Optimization (PGO) and LLVM BOLT HOT 13
- Replace iperf loadtest with fortio
- Consider Alternatives To DashMap
- Add build-step check for proto submodules HOT 1
- Add Support for Kubernetes native service routing via Gateway API v1 HOT 1
- ClusterMap::PartialEq is incredibly slow HOT 2
- Add licence.html to release quilkin.zip
- Agent <-> Relay communication is failing HOT 4
- Add lz4 compression HOT 2
- `Concatenate.Strategy.Prepend` should maybe be removed HOT 1
- Rust code generated from protobufs should be in source control
- CI is very slow HOT 1
- Cargo.lock should be committed
- Flaky Test: relay::tests::agones_token_router HOT 11
- Make delta xDS more efficient
- Documentation for xDS Delta API HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quilkin.