Comments (1)
These errors are coming from two places:
- https://github.com/GoogleCloudPlatform/open-match/blob/master/internal/statestorage/redis/redispb/redispb.go#L159
- https://github.com/GoogleCloudPlatform/open-match/blob/master/internal/statestorage/redis/redispb/redispb.go#L167
One case when errors happen there is when pbMap doesn't have a key: Sprintf'ed string will not be valid JSON then.
While working on this I noticed weird issue at first sight: Wrapping these places with error checks makes Backend API to start sending an empty MatchObject in a response to profile without "rosters" field set. After some debugging I think there's a bug in this same function that breaks Watcher:
- When Evaluator approves proposal it renames the key in Redis.
- To detect a fact of proposal approval the Backend's Watcher periodically calls UnmarshalFromRedis() which sends HGETALL under hood.
- According to Redis docs HGETALL returns empty list when key does not exist, and Redigo seem to not treat empty list as error. And this breaks the logic of Watcher's work since UnmarshalFromRedis() doesn't check for results' length. (It was working previously because of this "invalid character '}'" JSON bug which caused UnmarshalFromRedis() to return error making Watcher think that there's not results yet)
from open-match.
Related Issues (20)
- Various Issues with Tutorials
- Provide an example of any.Any use HOT 1
- RESOLVED - Mismatched Configmap Naming Convention, Custom Evaluator Tutorial Fails HOT 2
- zpages pprof seems to be unaccessable due to router problem
- Replace hpa from v1 to v2 HOT 1
- Add pod annotations to Helm templates for injecting user-specified pod annotations. HOT 2
- Release 1.8.0-rc.1
- flaky test in testing/e2e/backfill_test.go
- flaky test in testing/e2e/cluster_test.go
- Publish the Release on Open Match Blog.
- Release 1.8.0
- 1.8.0 YAML files still contain some jaeger traces
- How to configure a custom Redis password? HOT 1
- The helm chart have minReplicas set to 3 for query pods.
- add ability to set uo log output
- Helm chart `query.replicas` values are ignored if less than 3
- QUESTION: What must the contents of matchmaker_config_default.yaml and matchmaker_config_override.yaml be for minimatch? HOT 1
- Release 1.8.1
- failed to solve with frontend dockerfile.v0: failed to create LLB definition: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed HOT 1
- The tutorials cannot generate the docker images if the protobuf definitions changed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-match.