Git Product home page Git Product logo

Comments (1)

ihrankouski avatar ihrankouski commented on May 18, 2024

These errors are coming from two places:

One case when errors happen there is when pbMap doesn't have a key: Sprintf'ed string will not be valid JSON then.

While working on this I noticed weird issue at first sight: Wrapping these places with error checks makes Backend API to start sending an empty MatchObject in a response to profile without "rosters" field set. After some debugging I think there's a bug in this same function that breaks Watcher:

  • When Evaluator approves proposal it renames the key in Redis.
  • To detect a fact of proposal approval the Backend's Watcher periodically calls UnmarshalFromRedis() which sends HGETALL under hood.
  • According to Redis docs HGETALL returns empty list when key does not exist, and Redigo seem to not treat empty list as error. And this breaks the logic of Watcher's work since UnmarshalFromRedis() doesn't check for results' length. (It was working previously because of this "invalid character '}'" JSON bug which caused UnmarshalFromRedis() to return error making Watcher think that there's not results yet)

from open-match.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.