What happened : I attempted to use the new feature

I think we can probably close this. <a target="_blank" rel="noopener

Using portPolicy None results in a gameserver's port being 0 about agones HOT 5 CLOSED

KAllan357 commented on June 27, 2024

Using portPolicy None results in a gameserver's port being 0

from agones.

Comments (5)

KAllan357 commented on June 27, 2024 1

I think we can probably close this.

It looks like enabling the feature gate gets it to function the way I expect.

from agones.

markmandel commented on June 27, 2024 1

agones/pkg/apis/agones/v1/gameserver.go

Lines 514 to 532 in 27bf8a3

 func (gss *GameServerSpec) validateFeatureGates(fldPath *field.Path) field.ErrorList { 

 var allErrs field.ErrorList 

 if !runtime.FeatureEnabled(runtime.FeaturePlayerTracking) { 

 if gss.Players != nil { 

 allErrs = append(allErrs, field.Forbidden(fldPath.Child("players"), fmt.Sprintf("Value cannot be set unless feature flag %s is enabled", runtime.FeaturePlayerTracking))) 

 } 

 } 

 if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) { 

 if gss.Counters != nil { 

 allErrs = append(allErrs, field.Forbidden(fldPath.Child("counters"), fmt.Sprintf("Value cannot be set unless feature flag %s is enabled", runtime.FeatureCountsAndLists))) 

 } 

 if gss.Lists != nil { 

 allErrs = append(allErrs, field.Forbidden(fldPath.Child("lists"), fmt.Sprintf("Value cannot be set unless feature flag %s is enabled", runtime.FeatureCountsAndLists))) 

 } 

 } 

 return allErrs 

 }

Is where the validation should be added (in case people are looking).

from agones.

daniellee commented on June 27, 2024

Just to double check, it is behind a feature gate - have you enabled it?

https://agones.dev/site/docs/installation/install-agones/helm/#configuration - the value should be something like:"PortPolicyNone=true"

And could you show a bit more of your gameserver spec (with the sensitive info removed)?

from agones.

KAllan357 commented on June 27, 2024

Okay, I did not use the feature gate. I would maybe expect to receive an error if I was trying to use an gated feature. Let me try that later to see if the behavior changes.

Here is more of my Fleet definition:

apiVersion: "agones.dev/v1"
kind: Fleet
metadata:
  name: game-server
  labels:
    dev/changelist: "2024-06-12-6166-232"
spec:
  replicas: 1
  scheduling: Packed
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
  template:
    metadata:
      labels:
        dev/changelist: "2024-06-12-6166-232"
        app.kubernetes.io/name: game-server
        app.kubernetes.io/managed-by: Helm
    spec:
      container: game-server
      ports:
        - containerPort: 7777
          name: game
          portPolicy: None
          protocol: UDP
      health:
        initialDelaySeconds: 30
        periodSeconds: 20
        failureThreshold: 5
      sdkServer:
        logLevel: Info
        grpcPort: 9357
        httpPort: 9358
      template:
        metadata:
          labels:
            dev/changelist: "2024-06-12-6166-232"
            app.kubernetes.io/managed-by: Helm
        spec:
          containers:
            - name: game-server
              securityContext: {}
              image: "ECR"
              imagePullPolicy: Always
              env:
              resources: {}
              volumeMounts:
                - name: ini-overrides
                  mountPath: "blah"
                  subPath: FizzBuzz.ini
          imagePullSecrets:
            - name: ecr
          serviceAccountName: game-server
          securityContext: {}
          volumes:
            - name: ini-overrides
              configMap:
                name: game-server
                items:
                  - key: FizzBuzz.ini
                    path: FizzBuzz.ini
          nodeSelector:
            serverType: gameservers
          tolerations:
            - effect: NoSchedule
              key: serverType
              operator: Equal
              value: game

from agones.

markmandel commented on June 27, 2024

Okay, I did not use the feature gate. I would maybe expect to receive an error if I was trying to use an gated feature.

That is a bug though, if the feature gate is not enabled, we should throw a validation error. I'll leave this open, as we should fix this part.

from agones.

Using portPolicy None results in a gameserver's port being 0 about agones HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func (gss GameServerSpec) validateFeatureGates(fldPath field.Path) field.ErrorList {
	var allErrs field.ErrorList
	if !runtime.FeatureEnabled(runtime.FeaturePlayerTracking) {
	if gss.Players != nil {
	allErrs = append(allErrs, field.Forbidden(fldPath.Child("players"), fmt.Sprintf("Value cannot be set unless feature flag %s is enabled", runtime.FeaturePlayerTracking)))
	}
	}

	if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) {
	if gss.Counters != nil {
	allErrs = append(allErrs, field.Forbidden(fldPath.Child("counters"), fmt.Sprintf("Value cannot be set unless feature flag %s is enabled", runtime.FeatureCountsAndLists)))
	}
	if gss.Lists != nil {
	allErrs = append(allErrs, field.Forbidden(fldPath.Child("lists"), fmt.Sprintf("Value cannot be set unless feature flag %s is enabled", runtime.FeatureCountsAndLists)))
	}
	}

	return allErrs
	}