Migrate away from using the generate-groups script from k8s.io about agones HOT 8 CLOSED

should I switch to the new script once the PR for the Kubernetes version is merged, or should I make the change within that PR?

Let's do it in a new PR once that is merged. One problem at a time 😄

from agones.

Easiest way to check would be to run make shell and then look in /go/src/k8s.io/code-generator

from agones.

Regarding the generate-groups.sh script in the k8s.io/code-generator directory, I noticed that the kube_codegen.sh script is not present there. Will the kube_codegen.sh script be added to this directory automatically, or is there a different process for obtaining and using it?

:/go/src/agones.dev/agones# cd /go/src/k8s.io/code-generator/
:/go/src/k8s.io/code-generator# ls
CONTRIBUTING.md  OWNERS     SECURITY_CONTACTS  code-of-conduct.md  examples            generate-internal-groups.sh  go.sum  pkg          tools.go
LICENSE          README.md  cmd                doc.go              generate-groups.sh  go.mod                       hack    third_party

from agones.

The script kube_codegen.sh can be found in the code-generator repo at this link: https://github.com/kubernetes/code-generator/blob/master/kube_codegen.sh

Once kube_codegen.sh is available in the make shell; cd /go/src/k8s.io/code-generator/ directory, do we need to utilize it here - https://github.com/googleforgames/agones/blob/main/build/build-image/gen-crd-client.sh#L19?

from agones.

We can either vendor the code-generator repo (at the same branch version as we vendor client-go), or we can clone that github repository inside of our build image and execute it there.

from agones.

Thanks @roberthbailey👍🏻

Just for my notes: We have cloned the code-generator repo in here. When Agones updates to Kubernetes 1.30, we will switch from generate-groups.sh to kube-codegen.sh.

from agones.

When Agones updates to Kubernetes 1.30, we will switch from generate-groups.sh to kube-codegen.sh.

Just out of curiosity - I'm assuming the script doesn't exist in 1.29 ?

from agones.

Just out of curiosity - I'm assuming the script doesn't exist in 1.29 ?

I assumed that generate-groups.sh would be available until Kubernetes 1.30, However, I have verified that the new script is already present in Kubernetes version 1.28.6

root@deeaacff63a6:/go/src/k8s.io/code-generator# ls
CONTRIBUTING.md README.md code-of-conduct.md generate-groups.sh go.sum third_party
LICENSE SECURITY_CONTACTS doc.go generate-internal-groups.sh kube_codegen.sh tools.go
OWNERS cmd examples go.mod pkg

should I switch to the new script once the PR for the Kubernetes version is merged, or should I make the change within that PR?

from agones.