Git Product home page Git Product logo

Comments (11)

roozbehp avatar roozbehp commented on July 21, 2024

IIRC, this was supposed to be fixed in their latest delivery. So it may have been fixed by now. (Anyway, even if it's fixed, a unit test should be created to check for it so we don't regress.)

from roboto.

jungshik avatar jungshik commented on July 21, 2024

@roozbehp What's the latest delivery date of hinted Roboto ? I just pulled and the latest in the repo seems to be that of March 30. Do we have a newer delivery? If so, I want to use them on CrOS.

from roboto.

jungshik avatar jungshik commented on July 21, 2024

This is also an issue reported against CrOS ( http://crbug.com/462015 ) . Internal bug : https://b/19127020

For the record, this bug was moved from https://code.google.com/a/google.com/p/roboto/issues/detail?id=148

from roboto.

jungshik avatar jungshik commented on July 21, 2024

/cc @xiangye

from roboto.

jungshik avatar jungshik commented on July 21, 2024

I think it's fixed in the latest delivery (2015-06-25) which @jamesgk just checked in.

In the image below, the top is the latest Roboto and the bottom is Roboto (as of 2014-12-09). Both were taken with ftview (Freetype 2.5.5 with LCD aa with horizontal RGB).

screenshot from 2015-08-06 16 21 34

I counted the vertical pixels (of 'x' and 's' @12, 14, 16 ppem and of 'A' @16ppem) and confirmt that they match those of Roboto v1 (as reported by @roozbehp in comment 0) in the latest Roboto (top) while it has issues raised in this bug in 2014-12-09 snapshot (bottom).

I also did the same with grey-scale aa and got the same count. (btw, somehow, ftview and ftdiff in FT 2.6 and trunk always use grey-scale aa even when I selected LCD subpixel aa).

from roboto.

davelab6 avatar davelab6 commented on July 21, 2024

I think it's fixed in the latest delivery (2015-06-25) which @jamesgk just checked in.

I notice a few changes when comparing TTXs of the version currently in https://github.com/google/fonts/tree/master/apache/roboto and https://github.com/google/roboto/tree/master/hinted

  • The glyphorder has changed
  • The vertical metrics also changed, eg in the Condensed Bold from
    <sTypoAscender value="1536"/>
    <sTypoDescender value="-512"/>
    <sTypoLineGap value="102"/>
    <usWinAscent value="1946"/>
    <usWinDescent value="512"/>
    <ascent value="1900"/>
    <descent value="-500"/>

to

    <sTypoAscender value="2146"/>
    <sTypoDescender value="-555"/>
    <sTypoLineGap value="0"/>
    <usWinAscent value="2146"/>
    <usWinDescent value="555"/>
    <ascent value="2146"/>
    <descent value="-555"/>
  • Name IDs with platformID="1" were reintroduced.
  • The POST table regressed from v3 to v2, adding PSNames

from roboto.

jungshik avatar jungshik commented on July 21, 2024
  • The glyphorder has changed : Under normal circumstances, users of a font should never worry about this. It's a bug on the side of a font user/a downstream program to rely on the stable glyph order.

The following two issues are not regressions. They're supposed to be (and they're) taken care of by building 'web' target:

  • The POST table regressed from v3 to v2, adding PSNames
  • The vertical metrics also changed,

This one we may consider cleaning up.

  • Name IDs with platformID="1" were reintroduced.

from roboto.

davelab6 avatar davelab6 commented on July 21, 2024

Under normal circumstances, users of a font should never worry about this. It's a bug on the side of a font user/a downstream program to rely on the stable glyph order.

I agree, although it is worth noting :)

The following two issues are not regressions. They're supposed to be (and they're) taken care of by building 'web' target

I'm sorry, 'regression' is not the right word, I didn't intend its implications; I should have said 'decremented' (from v3 to v2) or just 'changed' :)

I'm curious why the POST table v2 is preferable for web fonts.

I also wonder if you could explain the vertical metrics change. I guess that this could be as disruptive for users as changing the hinted x height again, so I'd like to understand it :)

from roboto.

jungshik avatar jungshik commented on July 21, 2024

I also wonder if you could explain the vertical metrics change

It's NOT a change. Roboto has had what you called 'new metrics' for ages on Android (perhaps since J if not earlier).

I'm actually turning the table to you. Why in the world does Roboto in Google Fonts have different metrics than Roboto as shipped on Android and Chrome OS?

This issue is not a good place to discuss this issue. I'm filing an internal bug on this discrepancy.

from roboto.

jungshik avatar jungshik commented on July 21, 2024

I agree, although it is worth noting :)

I don't think it's worth noting. It's a non-event. ;-p.

from roboto.

davelab6 avatar davelab6 commented on July 21, 2024

Why in the world does Roboto in Google Fonts have different metrics than Roboto as shipped on Android and Chrome OS?

I actually don't think I really understand why. I'd be grateful if you could explain :)

from roboto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.