Git Product home page Git Product logo

Comments (3)

HappyHacker123 avatar HappyHacker123 commented on May 27, 2024

@blakeli0 @alicejli Could you help me review this issue? Many thanks :)

from jib.

chanseokoh avatar chanseokoh commented on May 27, 2024

First of all, you are not supposed to use or access BlobHttpContent. The intention is that only those classes under the api directiory are the public surface of the jib-core library.

(However, I admit I may not be understanding the gist of this issue.)

from jib.

HappyHacker123 avatar HappyHacker123 commented on May 27, 2024

@chanseokoh Thanks for your prompt reponese :).

Actually i'm mainly talking about the listed dependencies should be set to configuration api instead of implementation. The example of BlobHttpContent is just showing possible consequence of wrong configuration. Below are gradle official doc on api dependencies.

So when should you use the api configuration? An API dependency is one that contains at least one type that is exposed in the library binary interface, often referred to as its ABI (Application Binary Interface). This includes, but is not limited to:

  • types used in super classes or interfaces
  • types used in public method parameters, including generic parameter types (where public is something that is visible to compilers. I.e. , public, protected and package private members in the Java world)
  • types used in public fields
  • public annotation types

According to the doc, there are mainly four situations that the dependency should be set to api. So, in the above issue body, I'm listing where these dependencis meet one of these criteria and thus should be set to api.

from jib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.