Minor feature request - verify schema integrity before or when building deployment container about marketplace-k8s-app-tools HOT 6 OPEN

Another example of the sort of thing you run into at deployment container run-time. The error is clear and straightforward, it's just easier to catch earlier in the cycle.

May 9, 2018, 10:27:55 AM | config_helper.InvalidSchema: Property authEnabled has a default value of invalid type
-- | --
deployer | May 9, 2018, 10:27:55 AM | format(name))
deployer | May 9, 2018, 10:27:55 AM | File "/bin/config_helper.py", line 116, in __init__
deployer | May 9, 2018, 10:27:55 AM | for k, v in dictionary.get('properties', {}).iteritems()
deployer | May 9, 2018, 10:27:55 AM | File "/bin/config_helper.py", line 79, in <dictcomp>
deployer | May 9, 2018, 10:27:55 AM | for k, v in dictionary.get('properties', {}).iteritems()
deployer | May 9, 2018, 10:27:55 AM | File "/bin/config_helper.py", line 79, in __init__
deployer | May 9, 2018, 10:27:55 AM | return Schema(d)
deployer | May 9, 2018, 10:27:55 AM | File "/bin/config_helper.py", line 69, in load_yaml_file
deployer | May 9, 2018, 10:27:55 AM | args.schema_file_encoding)
deployer | May 9, 2018, 10:27:55 AM | File "/bin/expand_config.py", line 60, in main
deployer | May 9, 2018, 10:27:55 AM | main()
deployer | May 9, 2018, 10:27:55 AM | File "/bin/expand_config.py", line 123, in <module>
deployer | May 9, 2018, 10:27:55 AM | Traceback (most recent call last):
deployer | May 9, 2018, 10:27:55 AM | + /bin/expand_config.py

from marketplace-k8s-app-tools.

We actually wanted to do this, and thought about using ONBUILD. Unfortunately ONBUILD commands run right at FROM time.

Do you know of a way to have commands that run at the end of the inherited Dockerfile commands?

from marketplace-k8s-app-tools.

My thoughts were more basic. In the example, you have a Makefile that is dependent on all of these resources and that builds the Docker image. Seems the validation step happens in the Makefile maybe, reusing existing scripts you'd provide in tools, and the docker image doesn't get built at all (and the build fails) if schema validation doesn't happen.

I happen to use the Makefile, but even if someone else chose a different build setup, at least they'd see a validation example of how it's done, which they could adapt to whatever setup.

from marketplace-k8s-app-tools.

If we don't have a way to do it directly in the Dockerfile, totally agree that your proposal is the next best option.

We will look into adding that to the make targets. Thanks!

from marketplace-k8s-app-tools.

A way to do this in dockerfile would be possibly:

• COPY schema.yaml /tmp
• RUN validate.py schema.yaml > validated_schema.yaml
• RUN cp validated_schema.yaml /data/schema.yaml

If validation fails, the copy fails, and I get a message saying I'm missing a validated schema. Then you just need the guarantee that "validate.py" behaves to parse and re-dump the same content on validity. Or something like that.

from marketplace-k8s-app-tools.

That makes sense too. The only caveat is that it the creator of the inheriting Dockerfile has to add these commands. The nice thing about something like ONBUILD is that they would automatically inherit this (except it doesn't work as we wanted ;) ).

I think we will add this to both Makefile and Dockerfile. Useful for the user to pick whatever suitable for them.

from marketplace-k8s-app-tools.