CNRM containercluster missing ipAllocationPolicy fields needed to create private GKE clusters about kubeflow-distribution HOT 12 OPEN

https://github.com/GoogleCloudPlatform/k8s-config-connector

from kubeflow-distribution.

Issue-Label Bot is automatically applying the labels:

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

from kubeflow-distribution.

To edit the CRD:

1. Fetch the CRD

    kubectl get crd containerclusters.container.cnrm.cloud.google.com -o yaml > /tmp/container.crd.yaml
   

2. Open /tmp/container.crd.yaml and edit the schema to set ipallocationpolicy as mentioned in the previous comment.

3. Apply it

    kubectl apply -f /tmp/container.crd.yaml
   

from kubeflow-distribution.

Spoke to soon; doesn't look like this actually worked. The cluster ended up getting created on the default network; no subnetwork was created automatically.
https://gist.github.com/jlewi/29edc43a2b9cf7329f5274e7e35ad609

from kubeflow-distribution.

Is this still something that needs to be done? I wasn't sure if this was resolved already

from kubeflow-distribution.

I'm hoping by now this is resolved in newer versions of CNRM but need to double check and then should update the documentation (kubeflow/website#2190) appropriately.

from kubeflow-distribution.

Issue-Label Bot is automatically applying the labels:

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

from kubeflow-distribution.

/priority p1

from kubeflow-distribution.

After upgrading CNRM to 0.29.0 in KF 1.2 management cluster. I believe the issue has been fixed.
#152

Search for "ipAllocationPolicy" in https://cloud.google.com/config-connector/docs/reference/resource-docs/container/containercluster#spec

from kubeflow-distribution.

@Bodgy
Hello. The above problem is not yet solved.
I installed cnrm based on the changes that have been incorporated into the master branch, but the same error as above occurred.

Error from server: error when creating ".build/gcp_config/container.cnrm.cloud.google.com_v1beta1_containercluster_kubeflow.yaml": admission webhook "deny-unknown-fields.cnrm.cloud.google.com" denied the request: unknown field "spec.ipAllocationPolicy.createSubnetwork"
make: *** [apply-gcp] Error 1

$ kubectl get namespace cnrm-system -ojsonpath='{.metadata.annotations.cnrm\.cloud\.google\.com\/version}'
1.29.0

from kubeflow-distribution.

@TrsNium you are right. I didn't realize createSubnetwork field is not in the spec.

It doesn't seem like adding those fields will help.
I think this problem needs to be solved in the upstream repo. Has anyone created an issue there?

from kubeflow-distribution.

Hi has this issue been resolved? If not, we might be able to assists if we get more context into what's needed to get this up and running? All the GKE clusters we run are private cluster.

Best,

Royer R Ruiz

from kubeflow-distribution.