Enter PIN screen look different in iOS and Android about fda-mystudies HOT 7 CLOSED

+1 to this issue. The pin screen in iOS looks non-standard and has strange sizing and centering.

from fda-mystudies.

Additional issue with this screen: the text at the bottom of the screen (that allows the user to logout if they have forgotten their PIN) is too far down and is partially off the bottom of the screen

Screenshot attached.

from fda-mystudies.

It seems like the screen layout is a ResearchKit limitation. Why does the PIN code screen has to be implemented in ResearchKit?

from fda-mystudies.

@tushar-boston please provide your input. Any RK limitations here?

from fda-mystudies.

@tushar-boston please provide your input. Any RK limitations here?

Yes, the whole UI is rendering from RK.

from fda-mystudies.

Since the ResearchKit framework was being used for the rest of the iOS app, and because it provides the Passcode screen, it was used for this screen as well, unlike in Android where it was built as a custom screen. However, with newer OS versions, there have been some changes in the screen's appearance over time and across devices and screen sizes. While the team had done some optimization already, the screen still appears to be having issues in certain devices.

The iOS team has checked potential solutions and has identified some quick fixes that can be done for now (which includes tweaking a default RK value as well). This will solve some of the appearance issues for now (including the Cancel button appearing to be above the Forgot Passcode link), but the proper, long-term fix would be to upgrade to the latest RK version and/or apply customization, and that can be taken up as part of platform enhancement work subsequently.

The iOS team will raise a PR with the quick fix and we need another ticket to track that this change be reverted (the part that has a RK value tweaked) after this launch and replaced with a long-term fix subsequently for the repo. The long-term fix will not change the default RK values, and so developers who upgrade the app to newer versions of RK in the future, will not have issues related to this.

from fda-mystudies.

For ease of tracking, changed this issue to the bugs category to track the quick fix being done and the long-term solution has been raised as a new ticket and as an enhancement.

from fda-mystudies.