Comments (10)
Friendly ping on this, @Saaarah.
We're heavy users of cloud build and Slack and our notifications look like garbage and are really hard to tell apart:
We use cloud build + Slack notifications for:
- automated nightly deployments to test environments
- automated daily e2e tests (dev, staging)
- automated code/vulnerability scanners (on several branches)
- to notify about manual deployments as they happen / are successful (dev / staging / prod / demo / etc)
- pull requests (which don't notify)
If standardizing this is too much to take on now, WDYT about just letting the various projects do their thing? We already have implementations ready but which are bitrotting like #91
Or how about we just start with something simple like "subject/title + body in plaintext" for the payload?
from cloud-build-notifiers.
I noticed this part of the official statement from the Cloud Build Team:
...we plan on releasing here to open up the coding of this feature to the public.
So the community is expected to do the work of building this feature (no prob there, that's what open source is) but we're stuck indefinitely waiting for Google to publish a list of requirements.
This is inconsiderate of both the contributors and the users. Please either truly open this up so we can get community contributions merged in or raise the priority on publishing a list of requirements. I'm sure the community would be happy to collaborate in regards to creating the requirements in the interest of ensuring all notifiers follow a standard.
From what I've read, it seems the hold up centers around the fact that the message published to Pub/Sub doesn't contain information about the trigger or placeholders to add such information. I assume that's a problem because changing the message format might break existing integrations. If this is the case, why not just plan on publishing the data we need for custom messages to a separate queue?
Here's a proposal for the message format to get us started.
{
"project": "my-gcp-project",
"buildId": "91bc6340-0ce4-4789-aeaa-fbaf6a398552",
"duration": "1:45",
"images": [
"gcr.io/my-gcp-project/my-app:latest"
],
"source": "repo/my-app",
"trigger": {
"name": "my-build-trigger",
"repository": "repo/my-app"
},
"notifier": {
"customPlaceholders": {
"myPlaceholder": "Some value",
"anotherPlaceholder": "Another value"
},
"template": "This is my go template for {{.trigger.build}} with {{.myPlaceholder}} and {{.anotherPlaceholder}}."
}
}
from cloud-build-notifiers.
Hey @LOZORD, any movement on this?
from cloud-build-notifiers.
I see this commit 8 days ago b0668da
Does that mean that work is in progress for this?
The slack notifications are almost useless with the build ID instead of the friendly name.
from cloud-build-notifiers.
Hi Savvas, unfortunately I can't give an update as I no longer work on Cloud Build. @Saaarah might have a better idea.
from cloud-build-notifiers.
Any plans on moving this forward? We are using Cloud Build and have 10+ microservices, in different environments (staging, prod, etc). It would be really helpful to be aware of which of the services was deployed.
Thanks!
from cloud-build-notifiers.
Would be very useful to have this.
Also, I'd also suggest that it would be nice to have a simpler, container-based notifications that could either be directly part of Cloudbuild without creating any other resources, or a container based notification setup be embedded directly into workflows (similar to the Slack orb for CircleCI - https://circleci.com/developer/orbs/orb/circleci/slack).
Currently, the number of resources to setup and manage to get this working is quite a hassle for something that IMO should just be a builtin feature. The fact that the actual notifications themselves are not templatable or useful makes it even worse.
from cloud-build-notifiers.
Is there any progress on this, as others have stated the current notifications are kind of useless as they still require someone to view the logs to find out what service broken. In cases where multiple builds are failing, some of which are more/less important than others it would be very helpful to have some basic information added to the build notifications. Is there any work pending on the cloud build message that gets sent or work implementing the templating for the message?
from cloud-build-notifiers.
I'm amazed this was released without this functionality. Completely useless. Now I need to back it all out again.
from cloud-build-notifiers.
from cloud-build-notifiers.
Related Issues (20)
- Slack Notifier failed to unmarshal templating JSON HOT 6
- Failure to unmarshal E2_HIGHCPU_32 machineType
- allow optional configuration of log levels HOT 1
- [SLACK NOTIFIER] Region not contained in the url HOT 3
- [HTTP Notifications] Empty Body HOT 1
- Not able to use GCP Cloud Build Trigger Name in Email Subject or Body HOT 3
- {{.Build.FailureInfo.Detail}} doesn't work. HOT 1
- [SLACK] color side bar is not working in notification messages HOT 1
- Surfacing author / username information to Slack notifier (GH) HOT 2
- New line in a substitution fails Slack notification HOT 6
- Template vars passed to slack.json (Block Kit template) should escape or replace double quotation marks (ie. {{.Build.FailureInfo.Detail}}) HOT 1
- The user-provided container failed to start and listen on the port defined provided by the PORT=8080 environment variable HOT 6
- [Request] Allow using secret value for HTTP Notifier webhook
- should extract build id in another way when build status is unknown HOT 1
- Go Template `replace` function not found HOT 1
- SlackNotifier message notification popup says "no preview available" in Slack desktop client for Windows HOT 2
- SlackNotifier Error "field template not found in type notifiers.Notification" HOT 2
- Slack notifier fails to deploy because it doesn't listen to port 8080 HOT 7
- [REQUEST] Support for Bitbucket Commit Statuses HOT 1
- Slack notification: {{.Params.buildStatus}} substitution not working HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloud-build-notifiers.