Comments (5)
Hi,
I downloaded the plugin and had a look at the code. I think I found a bug in
how the proxy parameters were managed.
Here is my proposed patch:
diff --git a/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
b/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
index 6793085..f6c3148 100644
--- a/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
+++ b/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
@@ -236,6 +236,8 @@
arguments.add(action);
arguments.add(appDir);
+
+ getLog().debug("passing arguments: " + arguments.toString());
try {
AppCfg.main(arguments.toArray(new String[arguments.size()]));
@@ -280,13 +282,12 @@
}
if (proxyHost != null && !proxyHost.isEmpty()) {
- arguments.add("--proxy");
+ arguments.add("-p");
arguments.add(proxyHost);
}
if (proxyHttps != null && !proxyHttps.isEmpty()) {
- arguments.add("--proxy_https");
- arguments.add(proxyHttps);
+ arguments.add("--proxy_https="+proxyHttps);
}
if (noCookies) {
Original comment by [email protected]
on 6 Dec 2013 at 7:48
from appengine-maven-plugin.
I need this fix as well. The workaround that I used is to pass the proxy
settings on the maven command line:
mvn -DproxySet=true -DproxyHost=proxy.example.com -DproxyPort=8080 ...
But I definitely want the fix and not my band-aid. Ideally it would be nice if
this could use the maven proxy settings in my settings.xml.
Original comment by [email protected]
on 19 Dec 2013 at 9:39
from appengine-maven-plugin.
This bug applies to all parameters which expect an equal sign between the
parameter name and its value. So in the current version this bug should affect
parameters proxy, proxy_https, jar_splitting_excludes, num_days, severity e
num_runs.
I also need this fix.
Original comment by [email protected]
on 14 May 2014 at 5:35
from appengine-maven-plugin.
Fix will be in 1.9.7
For now, you can
$ git clone https://code.google.com/p/appengine-maven-plugin/
$ cd appengine-maven-plugin
$ mvn install
and use the version 1.9.7-SNAPSHOT in the plugin version as a workaround until
1.9.7 is pushed
Original comment by [email protected]
on 14 Jun 2014 at 4:58
- Changed state: Accepted
from appengine-maven-plugin.
Original comment by [email protected]
on 14 Jun 2014 at 4:58
- Changed state: Fixed
from appengine-maven-plugin.
Related Issues (20)
- Better integration with CircleCI
- Unable to deploy with `--use_google_application_default_credentials` option from Debian Jessie GCE instance. HOT 5
- Doesn't work with appengine 1.9.37 HOT 2
- specifying a custom dockerfile in configuration.dockerfile doesn't work for flex deployment
- provide mojo that starts, stops, clean without executing full lifecycle
- All unit tests fail w/ appengine-api-1.0-sdk-1.9.49.jar HOT 11
- update not working with 1.9.49 HOT 4
- Goal 'endpoints_get_discovery_doc' fails to execute on 1.9.49 HOT 3
- GAE deployment: appengine-maven-plugin:1.9.50:endpoints_get_discovery_doc : Null key for a Map not allowed in JSON
- Spring Boot Deploy HOT 1
- Google App Engine (GAE) - Flexible Environment - Jetty Issue HOT 2
- GCLOUD: ERROR: (gcloud.app.deploy) The requested resource already exists. HOT 1
- -Drun.profiles ignored during mvn appengine:deploy
- Getting 403 error but version is getting deployed with 0% traffic HOT 1
- appengine-maven-plugin vs app-maven-plugin HOT 2
- Allow running tasks without forking lifecycle.
- Unable to update app: Failed to generate quickstart-web.xml. HOT 1
- <version> seems to be required in appengine-web.xml to run locally
- Allow setting a specific port for secondary modules/services
- Project configuration is mandatory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appengine-maven-plugin.