Git Product home page Git Product logo

Comments (3)

ForbiddenEra avatar ForbiddenEra commented on May 26, 2024

Hi,

I think that perhaps there's some misunderstanding here. While having a timeout for taking a screenshot is great, this can easily be implemented on the developers side.

The original issue that I think people were asking for a fix for, was a timeout for if the screenshot fails/doesn't return within a certain period, for example, if you await page.screenshot() and then it never returns (IE, page context changed or went away) then your stuck hanging forever.

One could implement a promise timeout for this however it doesn't ensure that the call won't return in the future even after a timeout (unless it's truly and permanently hung) and is a different pattern than all other functions that have a timeout option to reject if not completed within the timeout.

from rendertron.

ForbiddenEra avatar ForbiddenEra commented on May 26, 2024

Also should mention that for your particular issue, you can wait for a specific element to be available, this is for example what we do on a page where content is loaded dynamically (a form) where we need to enter data.

from rendertron.

AVGP avatar AVGP commented on May 26, 2024

In general, as we're deprecating the project, you should look into alternative approaches to rendering on the web.

from rendertron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.