Git Product home page Git Product logo

Comments (22)

philipdbrown avatar philipdbrown commented on July 19, 2024 7

When instantiating the MarkerClusterer, you can pass a new path to the image set with the imagePath option:

var mc = new MarkerClusterer(map, makers, {imagePath: 'https://www.mydomain.com/m'});

that is also a quick fix. Although you can still change the js-marker-cluster, but I like to keep that clean. Just my thoughts.

from js-marker-clusterer.

nivas90 avatar nivas90 commented on July 19, 2024 5

When can we expect to see the commit done on the main branch? This is currently breaking our application.
Thanks

from js-marker-clusterer.

djozsef avatar djozsef commented on July 19, 2024 4

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

from js-marker-clusterer.

mluis avatar mluis commented on July 19, 2024 3

@djozsef perhaps the link should be this one?

https://cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/images/m

from js-marker-clusterer.

bunnyhero avatar bunnyhero commented on July 19, 2024 3

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

It's broken even on the documentation site's example pages :) (e.g. https://googlemaps.github.io/js-marker-clusterer/examples/simple_example.html )

from js-marker-clusterer.

 avatar commented on July 19, 2024 2

Two other issues already mention this (and include solutions): #55 #54

from js-marker-clusterer.

davidpelayo avatar davidpelayo commented on July 19, 2024 2

@mluis we have currently thousand of sites published (of our clients) which are visually failing because of this.... I mean, I thought these things were more serious within the different google organization departments...

from js-marker-clusterer.

diogolast avatar diogolast commented on July 19, 2024 1

thanks!!

from js-marker-clusterer.

davidpelayo avatar davidpelayo commented on July 19, 2024 1

@WACMemphis I agree. It depends on what you mean by saying failing.

However, the responsibility of these actions considering how many people have been using this solution for production-apps it's high enough for double-checking beforehand.

from js-marker-clusterer.

 avatar commented on July 19, 2024 1

@davidpelayo Yes, I'm with you on this. I have to update quite a few applications myself.
I'm opting to use my own images from now on though.

BTW, left a comment on your commit.

from js-marker-clusterer.

brianhogg avatar brianhogg commented on July 19, 2024 1

I've been passing in the MAPPARAMS.imageurl var to set your local path to the images, but the markerclusterer_compiled.js script (or _packed.js in the old version) does not seem to look at this. It appears to be hard coded to the googlecode.com repo.

The attached minified version does the trick.
markerclusterer.min.js.zip

from js-marker-clusterer.

wedneyyuri avatar wedneyyuri commented on July 19, 2024 1

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

In my opinion, the imagePath option should be optional but throw a warning if not passed.

from js-marker-clusterer.

KashifAhmed avatar KashifAhmed commented on July 19, 2024 1

For time being replace MARKER_CLUSTER_IMAGE_PATH_ with
'https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m'

This trick work for me.

from js-marker-clusterer.

yannbug avatar yannbug commented on July 19, 2024

+1

from js-marker-clusterer.

djozsef avatar djozsef commented on July 19, 2024

@mluis Sound like a plan! I am not sure if it is a proper canonical way but should work even in master as default imagePath.

from js-marker-clusterer.

davidpelayo avatar davidpelayo commented on July 19, 2024

This unplanned change has caused bugs on thousand of applications. I consider resources shouldn't have been deleted, though.

from js-marker-clusterer.

mluis avatar mluis commented on July 19, 2024

That's out of my realm but I agree that this should have been a soft handover.

from js-marker-clusterer.

 avatar commented on July 19, 2024

@davidpelayo I fully understand you, but "failing" is maybe a bit much. The markerclusterer still works, it's just the images that don't show up.

from js-marker-clusterer.

PeterTheOne avatar PeterTheOne commented on July 19, 2024

fixed by 2f659a3

from js-marker-clusterer.

sudheerec107 avatar sudheerec107 commented on July 19, 2024

Suppose if i have many clusters in my map and i want clusters with different color depending on some value. How to achieve this.

from js-marker-clusterer.

cmcintosh avatar cmcintosh commented on July 19, 2024

from js-marker-clusterer.

sebastiangug avatar sebastiangug commented on July 19, 2024

All of the links in this thread are 404 now.

Thanks google.

from js-marker-clusterer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.