Support the asynchronous maps API. about js-map-label HOT 7 OPEN

I think we can just add

this.prototype = new google.maps.OverlayView; to the constructor.

@brendankenny wdyt?

from js-map-label.

Wait no, that would override all of the other methods we've added already. Hm.

from js-map-label.

Assigning the prototype like that would happen too late. When you assign the prototype within the constructor, it's assigned after first instantiation. Copying the OverlayView properties to extend MapLabel is the simplest method I can think of.

from js-map-label.

JimBobSquarePants: Your solution works, thanks. Perhaps open a pull request?

from js-map-label.

I'm experiencing the same issue as @JimBobSquarePants
I need to load maps APIs asynchronously because I'm passing API key to it, which is a configuration param of my app.
👍 for a pull request.

from js-map-label.

I experienced the same error.
I loaded GoogleMapApi asynchronously with a callback function and an attribute defer.
A script dependant on GoogleMapApi was loaded without async and defer. This caused the error in the customized OverlayView: this.setMap is no function.
Adding the defer attribute to the script tag dependent of GoogleMapsApi solved the issue.
The main parts of my code:

    <script async defer type="text/javascript"
    src="https://maps.google.com/maps/api/js?language=de&amp;key=MyKey&amp;callback=initMap">
     </script>
    <script type="text/javascript" src="lib/routeMain.js" ></script>
    <script defer type="text/javascript" src="lib/markermanager.js"></script>

In routeMain.js:

function initMap() {
if (typeof console !== 'undefined' && typeof console.log !== 'undefined') {
console.log('GoogleMapsApi loaded.');
}
}
document.addEventListener('DOMContentLoaded', function () {
if (typeof console !== 'undefined' && typeof console.log !== 'undefined') {
console.log('+++main page was loaded.');
}
initialize();
}, false);
var map;
function initialize() {
var latlng = new google.maps.LatLng(51.31893, 9.49601); //Kassel, Germany
var myOptions = {
zoom: 7,
center: latlng,
mapTypeControl: true
};
map = new google.maps.Map(document.getElementById("map_canvas"), myOptions);
}

from js-map-label.

Any solution on this issue.
I tried using fhackenberger 's edited code. But now I am getting error :- Uncaught ReferenceError: MapLabel is not defined

from js-map-label.