Comments (4)
@Neenu1995 @chingor13 FYI
from sdk-platform-java.
This null check originates from the monolith generator. On investigating, this was introduced for a very specific reason, context below.
- Original bug
- Relevant discussion in the bugfix, where the necessity of this check was initially debated.
I'll add a comment to the code to indicate this check is WAI. Removing this check would introduce a bug in client libraries who do return null instead of an empty list, so closing this issue.
from sdk-platform-java.
Going to reopen. The bug and discussion refer to com.google.api.services.compute.model.Image
, note the model
in the name. This refers to the old HTTP generated libraries, not protobuf libraries, indeed you can see it overrides GenericJson not AbstractMessage. Are there still generated clients which use the old HTTP bindings, not the protobuf ones? If so, this check may indeed be necessary for those clients. But if no such libraries are generated (or generatable) with the version at head, this check may safely be removed.
from sdk-platform-java.
The microgenerator supports a superset of the monolith's features, and it's unclear if there are clients who do the same thing as the use case mentioned in the original bug. I would prefer not to introduce a potential breakage to one of the ~200 client libraries we support, but if you can confirm that none of them return null instead of an empty list (and paste that here), we can revisit making this change.
In the meantime, the import issue can be addressed by post-processing the generated library, either manually (as is currently done) or with a script.
from sdk-platform-java.
Related Issues (20)
- Nightly-java8 build on macOS-12 failed. HOT 1
- Nightly-java8 build on windows-2022 failed.
- Nightly-java8 build on macOS-12 failed.
- Nightly-java8 build on windows-2022 failed.
- Nightly-java8 build on windows-2022 failed.
- Nightly-java8 build on macOS-12 failed.
- Nightly-java8 build on windows-2022 failed.
- Nightly-java8 build on macOS-12 failed.
- Nightly-java8 build on macOS-12 failed.
- Nightly-java8 build on windows-2022 failed.
- Verify update of cloudbuild-*.yaml files in next release (after 2.31.0) HOT 1
- Nightly build for Java 17 on ubuntu-22.04 failed.
- Release Please is not updating WORKSPACE file for _gapic_generator_java_version HOT 7
- Warning: a recent release failed HOT 1
- ObsoleteApi: `getDefualtEndpoint()` in the generated ServiceStubSettings
- Nightly build for Java 11 on ubuntu-22.04 failed.
- Nightly-java8 build on macOS-12 failed. HOT 2
- gax: Using DirectPath fails with NPE when using NoCredentialsProvider to support Downscoped tokens HOT 8
- Nightly build for Java 17 on macOS-12 failed. HOT 2
- Nightly build for Java 11 on macOS-12 failed. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk-platform-java.