Comments (3)
Hi @nwbirnie,
This looks doable, since TransportChannelProvider
is @InternalExtensionOnly
and GrpcInterceptorProvider
and LocalChannelProvider
are @BetaApi
(so we can add extensions without formally breaking backward compatibility).
At the same time, this will also require "shading" io.grpc.ClientInterceptor
(wrapping it in some other class, so TransportChannelProvider
can stay unaware of grpc), which is going to look sloppy. Or, making some empty TransportInterceptorProvider
(without methods) and do explicit casting inside implementations, which is also bad oop design. There are must be other options as well but I can't think of any better ones right now.
So if there is a strong reason to do it we definitely can do it, but otherwise I think it would be better to not do it as it somewhat worsens gax's surface.
from sdk-platform-java.
So the motivation here is testing. I'm using MockServiceHelper and LocalChannelProvider to test headers being sent in RPCs. I'd like to expand the test scope to include interceptors. Is there another way to test that interceptors are being invoked in unit tests?
In terms of the shading approach, I don't think this is so bad - we're effectively doing the same thing for headers/endpoints etc. except those happen to be native types. Increasing decoupling and adding features to GAX seems like a good option in general.
from sdk-platform-java.
@vam-google Do you have any updated thoughts on this?
from sdk-platform-java.
Related Issues (20)
- Nightly build for Java 11 on ubuntu-22.04 failed. HOT 1
- Nightly build for Java 11 on macOS-12 failed. HOT 1
- Nightly build for Java 17 on windows-2022 failed. HOT 1
- Nightly build for Java 11 on windows-2022 failed. HOT 1
- Nightly build for Java 17 on macOS-12 failed. HOT 1
- Nightly-java8 build on windows-2022 failed. HOT 1
- Nightly build for Java 11 on macOS-12 failed. HOT 1
- Nightly-java8 build on macOS-12 failed. HOT 1
- The java-spanner downstream check started failing since #1872
- The java-bigtable downstream check started failing since #1872
- Investigate using a Mock gRPC Channel for InstantiatingGrpcChannelProviderTest
- Nightly-java8 build on macOS-12 failed. HOT 2
- bazel build failures when grpc dependencies upgrades to v1.65.0 HOT 1
- Unmanaged dependency check: false positive in jspecify HOT 4
- Generator is creating Callables based on RPC suffix
- Investigate usages of `Map<String, VariableExpr>` in AbstractTransportServiceStubClassComposer
- setup repo required checks in .github/sync-repo-settings.yaml
- Unmanaged dependency checks failing at shared-resourcemapping HOT 4
- [Policy Bot] found one or more issues with this repository.
- Warning: a recent release failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk-platform-java.