Comments (6)
antonmedv
commented on May 7, 2024
1
Done.
from zx.
antonmedv
commented on May 7, 2024
Maybe it’s better to add check in package.json?
from zx.
tobilg
commented on May 7, 2024
I thought about that as well, but wasn't sure if that would really help as you can use an IIF as workaround for older versions, and the engine property in the package.json is only advisorial unless engine-strict is used (see https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines).
So I chose to only add some info to the README. What do you think?
from zx.
tobilg
commented on May 7, 2024
@antonmedv I currently don't see a hint in the README.md, and in the package.json there's only a reference to the "wrong" Node version with top-level await support (see https://github.com/google/zx/blob/main/package.json#L11)
from zx.
antonmedv
commented on May 7, 2024
What version is minimal supposed?
from zx.
tobilg
commented on May 7, 2024
It's v14.8.0 according to https://dev.to/mikeesto/top-level-await-in-node-2jad
Please also see my PR https://github.com/google/zx/pull/9/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R35
from zx.
Related Issues (20)
- Drop Node.js v16 and node-fetch dependency HOT 1
- `which` utility not working correctly when using `$.prefix`
- feature request: trim option HOT 11
- feature request: shorter commands for common patterns HOT 1
- windows execution failed
- Feature request: hiding user input HOT 2
- Template strings have some parsing bugs HOT 1
- Imported `argv` includes the filename
- Feature request: support "minutes" for duration
- ssh() is undocumented HOT 1
- ssh() fails: "Control socket connect" HOT 1
- Shell variable in args array not expanded HOT 2
- Feature request: Process Promise verbose() HOT 1
- Self-introduction: GitHub Action `run-zx`
- Reduce package installation size HOT 3
- Feature request: nothrow() only for a subset of error codes
- Allow multiple lines of hashbangs
- $`readlink` always throws error HOT 2
- An easy way to specify stdin HOT 3
- Replacing globby with a lighter alternative HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zx.