Comments (2)
> while (scan < safe_end && *((size_t*)scan) == *((size_t*)match)) {
If scan is not integer aligned, then that will cause unaligned accesses. In
x86, this is a performance problem. In other architectures, it results in a
SIGBUS like you are seeing.
It seems to me that there should be a bit of code before the while loop that
advances scan up to the next alignment boundary, like you find in optimized
memcmp implementations. Once scan is aligned, then the optimized loops (for 8
and 4 bytes) can be used.
Original comment by [email protected]
on 10 Jan 2014 at 12:56
from zopfli.
Compiling with -fsanitize=undefined
results in runtime errors for these unaligned reads. I believe it could also potentially be violating the strict aliasing rule.
from zopfli.
Related Issues (20)
- how to working in iOS? HOT 1
- Do not emit compressed files larger than the input
- Add lgtm to the repo and fix its issues
- better cmake build
- compiler warnings
- Order of colors in PLTE not kept anymore
- Zopflipng picks up crc errors in input files, offers to disable checks, but no crc check disable switch found
- Null Dereference
- Would you please describe the zopfli block-splitting heuristic? HOT 1
- using `--lossy_transparent` option sometimes results in higher file size
- Incorrect ZopfliPNG static library build rule
- verification of result failed HOT 1
- Time for a new release? HOT 2
- Document ZopfliDeflate parameters
- Assertion failed on ZopfliCalculateBitLengths at zopfli/src/zopfli/tree.c:100
- unnecessary `else` statement.
- Android
- OSS-Fuzz issue 57919
- katajainen.c has executable flag
- "Invalid filename" successful
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zopfli.