Git Product home page Git Product logo

Comments (2)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
> while (scan < safe_end && *((size_t*)scan) == *((size_t*)match)) {

If scan is not integer aligned, then that will cause unaligned accesses. In 
x86, this is a performance problem. In other architectures, it results in a 
SIGBUS like you are seeing.

It seems to me that there should be a bit of code before the while loop that 
advances scan up to the next alignment boundary, like you find in optimized 
memcmp implementations. Once scan is aligned, then the optimized loops (for 8 
and 4 bytes) can be used.

Original comment by [email protected] on 10 Jan 2014 at 12:56

from zopfli.

jibsen avatar jibsen commented on August 30, 2024

Compiling with -fsanitize=undefined results in runtime errors for these unaligned reads. I believe it could also potentially be violating the strict aliasing rule.

from zopfli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.