Git Product home page Git Product logo

Comments (5)

davidben avatar davidben commented on April 28, 2024

I wrote a quick tool to compare the combined and split up files. The RSA and ECDSA split up ones do seem to be larger, as one would expect. I'm guessing, e.g., some edge cases were only tested at certain hashes or key sizes and now you do them everywhere. However there is a large discrepancy between the tests in both direction. Sampling a few, it looks like the RSA and ECDSA tests ended up using different random seeds between split up and combined. Is that correct?

ECDH is odd as ecdh_test.json tests brainpool*t1 curves, but there aren't separated files for them. After correcting for that, the test counts and most of the tests match. There are 10 "public key of order 3" that have slightly different value, but I gather those too are just a difference in random seed.

from wycheproof.

thaidn avatar thaidn commented on April 28, 2024

@bleichen

from wycheproof.

bleichen avatar bleichen commented on April 28, 2024

The general plan is to split large files into more files based on curves or key size and leave odd cases in the unparametrisized file. ecdsa_test.java, ecdh_test.java are just too large right now and will be reduced.
The current state is a bit unfortunate, since they were published in the middle of this transition.

Documentation in general is quite bad. It is still unclear what to use:
I.e. the minimum requirement would be to have support for equations and references and be simple to
use. Markup on github is unfortunately lacking almost every useful feature. It actually seems to be worse
than Microsoft word from 30 years ago.

from wycheproof.

alex avatar alex commented on April 28, 2024

A question that came up for us: is ecdsa_test.json a concatention of all of the other ecdsa_*_test.json files, or does it contain it's own things?

from wycheproof.

bleichen avatar bleichen commented on April 28, 2024

from wycheproof.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.