Git Product home page Git Product logo

Comments (8)

thaidn avatar thaidn commented on April 28, 2024 1

Hi Brian,

The tcId aren't stable for now.

@bleichen Daniel, can we keep the tcId stable?

from wycheproof.

bleichen avatar bleichen commented on April 28, 2024

No. tcIds are not stable. They change every time the test vectors are generated and are only useful as identifier of a test vector if the version
of the test vectors is also known. There are no plans to make them stable. I.e. the test vector generation often sorts the test vectors by key so that vectors with the same key are in the same test group. So adding test vectors to one group, changes the tcIds in the next group.

For citing a test vector, it is probably reasonable to just copy the test vector.
For excluding test vectors with legacy behavior, I'm adding flags to the test vectors.
For documentation there are comments in the test vectors that can point to CVE or other
references.

from wycheproof.

briansmith avatar briansmith commented on April 28, 2024

OK, thanks for the explanation.

For citing a test vector, it is probably reasonable to just copy the test vector.

I understand that the test vectors aren't copyrightable and so the license doesn't apply to them. However, it would be great if that could be made explicit in the LICENSE file.

from wycheproof.

thaidn avatar thaidn commented on April 28, 2024

The main question is answered, so I'm going to close this ticket.

from wycheproof.

thaidn avatar thaidn commented on April 28, 2024

I understand that the test vectors aren't copyrightable and so the license doesn't apply to them. However, it would be great if that could be made explicit in the LICENSE file.

(reopening this because this was discussed internally)

Hey Brian,

Just curious, why you think the test vectors are not copyrightable? Can you use them even if they are under the Apache 2 license? We want you to use them, but we're not sure if we can convince the lawyers to exclude the test vectors from the copyright notice.

from wycheproof.

thaidn avatar thaidn commented on April 28, 2024

Friendly ping Brian.

from wycheproof.

briansmith avatar briansmith commented on April 28, 2024

I am able to use the test vectors without any changes.

from wycheproof.

thaidn avatar thaidn commented on April 28, 2024

Cool.

from wycheproof.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.