wire: share dependency graph across injectors in the same package? about wire HOT 6 CLOSED

Wire intentionally does not have a notion of subcomponents at the moment. In talking with the Dagger team, we discovered that subcomponents and scopes introduce a fair amount of complexity.

As you say, you can get much the same behavior by returning the singletons from the first injector that creates them and then pass them to later injectors. This has the benefit of making the dataflow explicit, which for the examples we came up with, seemed like a net win. That said, we're very curious to see how folks will use Wire in real-world applications: if this does not scale, we might have to revisit.

EDIT: I realized after looking more closely at your sample that the component itself is stateful (a detail I had forgotten about Dagger). My explanation above is still largely applicable: we want state to be explicit.

from wire.

FWIW, in the meantime I'm using a technique similar to your Options example to inject a struct with all the values I need. The disadvantage of this is that each value is eagerly injected regardless of when it is needed, but it certainly works for now.

Thanks!

from wire.

For reference, here is a minimal example that shows the behavior I'm describing in a dagger 2 project:

https://github.com/drewolson/dagger_maven_example/tree/singleton_across_providers

This is the test that asserts the behavior.

from wire.

EDIT: I realized after looking more closely at your sample that the component itself is stateful (a detail I had forgotten about Dagger).

Yes, this is where I was going with this conversation. Perhaps, in the future, there could be some kind of alternative injectors that are attached to a struct where state is tracked. I definitely agree that starting out simple and waiting for real-world experience reports is the right approach.

Thanks again for this great library, I look forward to using it in my projects.

from wire.

@drewolson I found this issue 5 years later while looking up the same thing - how to share dependencies across injectors (eg reusing one DB connection-pool among multiple DAOs). Unfortunately, the links you posted are dead now and I'm not sure what you're referring to when you mention the "Options example".

Could you please share some updated links (or better, sample code) to explain how you managed to share dependencies between injectors? Also, what is the "Options example" you were referring to?

from wire.

After some doing some more research, I found issue #260 where they basically resolve this issue by declaring an App super-container struct that has all the top-level dependencies for the application. Then there's only a single injector declared in the wire.go file which will naturally instantiate all dependencies once and then reuse them.

Sample code:
wire.go

type App struct {
	*services.AuthService
	*services.FooService
}

var daoSet = wire.NewSet(
	dao.NewAuthDAO,
	dao.NewFooDAO,
)

var svcSet = wire.NewSet(
	services.NewAuthService,
	services.NewFooService,
)

func InitializeApp() *App {
	wire.Build(
		dao.InitDB,
		daoSet,
		svcSet,
		wire.Struct(new(App), "*"),
	)
	return nil
}

Then after generating the wire_gen.go file by invoking wire in the terminal, we can invoke InitializeApp() to get the dependencies we need.

For the Options stuff, I found this doc page about using an Options struct which is what I assume you were referring to: https://github.com/google/wire/blob/main/docs/best-practices.md#options-structs

// A provider function that includes many dependencies can pair the function with an options struct.

type Options struct {
    // Messages is the set of recommended greetings.
    Messages []Message
    // Writer is the location to send greetings. nil goes to stdout.
    Writer io.Writer
}

func NewGreeter(ctx context.Context, opts *Options) (*Greeter, error) {
    // ...
}

var GreeterSet = wire.NewSet(wire.Struct(new(Options), "*"), NewGreeter)

from wire.