Git Product home page Git Product logo

Comments (5)

annagrin avatar annagrin commented on May 3, 2024

@devoncarew I see this issue is closed as completed but it is not clear to me what the changes were... Is there a way to pass an error handler to the created socket connection? Maybe an onError error handler parameter could be added to

static Future<WipConnection> connect(String url) {

and subsequently, its caller:

Future<WipConnection> connect() =>

Or maybe we can provide an onError stream similar to onClose :

Stream<WipConnection> get onClose => _closeController.stream;

from webkit_inspection_protocol.dart.

devoncarew avatar devoncarew commented on May 3, 2024

I believe it was closed as a result of #88; I'm 100% that addresses all of this issue however (or whether that work was rolled into flutter?).

from webkit_inspection_protocol.dart.

annagrin avatar annagrin commented on May 3, 2024

The #88 allows retries on connection to chrome tab, the current issue is asking for error handling if a debug connection stops working for any reasons so the caller (dwds) can report it in the logs. The original issue is in flutter, it seems that the connection just stops working and we cannot get the error and the stacktrace.

from webkit_inspection_protocol.dart.

devoncarew avatar devoncarew commented on May 3, 2024

Sorry, above I meant to say 'not 100% sure'!

Yes, we can augment the API here in order to better pass errors through.

Let me take a look at the API here. I'm not sure whether we want an onError error handler parameter, or just to pass failures back through the returned Futures.

from webkit_inspection_protocol.dart.

devoncarew avatar devoncarew commented on May 3, 2024

Address in #92 and published as 1.2.0.

from webkit_inspection_protocol.dart.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.