Git Product home page Git Product logo

Comments (4)

pangeran-bottor avatar pangeran-bottor commented on July 27, 2024 1

Hi @alxmrs, I plan to work on this and have a couple of questions:

  1. should the CLI accept multiple configs as something like this:
    weather-dl config_1.cfg config_2.cfg --local-run
    or we just accept a folder path contains all the configs e.g.:
    weather-dl --config_folder /path/to/configs --local-run

  2. I assume the option would be applied to all the configs, is that correct? So for the above example, we run every config on the local machine.

Thank you!

from weather-tools.

pangeran-bottor avatar pangeran-bottor commented on July 27, 2024 1

Regarding the license, my first thought was each config file gets a say. For example, at first, we execute:
weather-dl config_1.cfg config_2.cfg --local-run,
but then somehow later we need to redownload only for config_2.cfg and since all flags applied to all the configs, we need to execute:
weather-dl config_2.cfg --local-run --force-download.
Would it be easier if config_2.cfg has its own params? Am I missing something on the tool's design?

  1. The former. Users can use a glob star pattern to specify a folder of configs if they wish. On that note, we can encourage that usage by documenting examples of it.
  2. Yes, all the flags applied should apply to all the configs.

Thanks and well noted on this.

from weather-tools.

alxmrs avatar alxmrs commented on July 27, 2024 1

Ok, that makes sense to me. I like the example use case you bring up. Further, thinking about it more, the tool would be a bit more fragile if the order of arguments was important for the flow of execution. Better to strictly follow the interface we establish elsewhere.

You're not missing anything. One reason why I suggested the other approach is that it may make the implementation simpler.

from weather-tools.

alxmrs avatar alxmrs commented on July 27, 2024

Hey @pangeran-bottor, thanks for your contribution! A few thoughts:

  1. The former. Users can use a glob star pattern to specify a folder of configs if they wish. On that note, we can encourage that usage by documenting examples of it.

  2. Yes, all the flags applied should apply to all the configs.

Last, an open question: What parameters should take precedence? The first config's params, or does each config file get a say? Of particular concern here is how licenses are applied. For example, it would be convincing if I only needed to add licenses to the first config and they magically appeared in all of the rest. What are the downsides to doing this? Is this design question clear? Do you have an opinion on the matter?

from weather-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.