Comments (3)
I have a feeling that this is the function that I should be working on
I'll add the value of ST_GeogPoint(longitude,latitude) to the existing column
This sounds right to me. I recommend looking at the logic here (https://github.com/google/weather-tools/blob/main/weather_mv/loader_pipeline/pipeline.py#L370). I think the column should be added around this area, and to the associated functions. Check out this BQ documentation, too: https://cloud.google.com/bigquery/docs/geospatial-data
Would you say that trying to understand the code while fixing this issue be a good starting point?
Yes, I think this is a great starting point. If you'd like additional help, maybe we can set up a 1:1 meeting.
Also, I would greatly appreciate it if you could share any good practices I should follow or keep in mind when contributing to a preexisting project.
Sure thing. The general flow will look like:
- Fork the project
- Make the change in a new branch (not the main branch)
- Test your code (unit tests, manually e2e)
- Send a draft pull request into the main branch (see the Github docs for clarity on how to do this)
- Review the code yourself, see if you can catch any errors before it goes to final review. Also, you can see if any errors have occurred on the automated check system (to run them locally, use
bin/post-push
) - Once it's ready, send the code out for review
- iterate on the branch until all outstanding feedback is addressed
- if you need help testing the pipelines e2e, please say so.
- Change will be merged into main.
How does all that sound?
from weather-tools.
Hi @alxmrs, I plan on working on this but I am still in the process of trying to understand the code.
https://github.com/google/weather-tools/blob/82971d0559c0d567133e8191d4112a0879a0d888/weather_mv/loader_pipeline/pipeline.py#L250
I have a feeling that this is the function that I should be working on and that I'll add the value of ST_GeogPoint(longitude,latitude) to the existing column but I'm not too sure. Would you say that trying to understand the code while fixing this issue be a good starting point? Also, I would greatly appreciate it if you could share any good practices I should follow or keep in mind when contributing to a preexisting project.
from weather-tools.
Heads up: The files changed around a lot in #101.
from weather-tools.
Related Issues (20)
- `gcloud alpha commands` used but not installed in enviroment
- ruff not used in CI pipeline
- Missing ruff checks
- Don't keep NULLs in the CSVs for feature collection
- Provide support to give time range while opening zarr HOT 1
- weather-mv rg gave data with offset by 180 degree longitude.
- weather-sp: Provide an option to append the filename with the splitted filename.
- weather-mv bq raster issue while reading ecmwf grib file HOT 2
- Find a way to exclude test data when building docker image. HOT 2
- All tools should make use of public runtime container image to manage dependencies
- weather-mv ee: Add a couple of time-metrics to asset attributes
- Deprecated Apache Beam Version Causing Error in weather-dl tool.
- Make use of secret-manager while using weather-dl for license keys. HOT 1
- Enhanced support in weather-dl for downloading data across month ranges spanning multiple years. HOT 1
- Add new functionality (--async) in weather-dl to terminate tool after dataflow job launched.
- Strengthen feature collection ingestion logic in weather-mv
- [CI/CD failing] Ruff version deprecated. HOT 2
- Add a feature in weather-mv to extract specific date's data from any files.
- Faster ingestion into BQ by converting the chunk into pd.Dataframe
- Pangeo Showcase talk on weather-tools/xql? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from weather-tools.