Git Product home page Git Product logo

Comments (6)

pranay101 avatar pranay101 commented on July 27, 2024

Hi, I am new to open source and I would like to work on this issue. Please guide me further on what needs to be done.

from weather-tools.

CillianFn avatar CillianFn commented on July 27, 2024

Hey @pranay101 ! More information can be found about what configuration files are used for here

As outlined, Configuration files can be written in *.cfg or *.json. However the examples in the config directory only contains examples of *.cfg files.

It would be useful to have some *.json examples also. I suggest creating json versions of some of the cfg examples. These can then be tested locally to ensure the same behaviour is observed e.g.

weather-dl configs/era5_example_config_local_run.cfg --local-run
should work the same as,
weather-dl configs/era5_example_config_local_run.json--local-run

from weather-tools.

alxmrs avatar alxmrs commented on July 27, 2024

I like the idea of having JSON configs. It's worth noting that the JSON representation will not be as full featured as the ConfigParser. See: https://github.com/google/weather-tools/blob/main/weather_dl/download_pipeline/parsers.py#L72

I think we can still create JSON example configs; however, these will have to be more verbose for the time being.

from weather-tools.

alxmrs avatar alxmrs commented on July 27, 2024

xref: #48

from weather-tools.

pranay101 avatar pranay101 commented on July 27, 2024

Hey @pranay101 ! More information can be found about what configuration files are used for here

As outlined, Configuration files can be written in *.cfg or *.json. However the examples in the config directory only contains examples of *.cfg files.

It would be useful to have some *.json examples also. I suggest creating json versions of some of the cfg examples. These can then be tested locally to ensure the same behaviour is observed e.g.

weather-dl configs/era5_example_config_local_run.cfg --local-run should work the same as, weather-dl configs/era5_example_config_local_run.json--local-run

how should I structure the project then?. creating separate folders for .CFG and .JSON inside config. or should I place json file along with the cfg files.

from weather-tools.

alxmrs avatar alxmrs commented on July 27, 2024

I'm a fan of flat file structures. So, json next to cfg sounds good to me.

from weather-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.