Assume a link to be a "patch link" only if tagged as `Patch` by NVD about vulncode-db HOT 6 CLOSED

Thanks that's good to know! Unfortunately, the dependency https://github.com/kotakanbe/go-cve-dictionary/ we use to fetch and incorporate the NVD data seems to be unaware of Reference tags such as Third Party Advisory.

Particularly, looking at: https://github.com/kotakanbe/go-cve-dictionary/blob/master/models/models.go#L257

// Reference is Child model of Jvn/Nvd.
// It holds reference information about the CVE.
type Reference struct {
	gorm.Model `json:"-" xml:"-"`
	NvdJSONID  uint `json:"-" xml:"-"`
	JvnID      uint `json:"-" xml:"-"`

	Source string
	Link   string `sql:"type:text"`
}

You can see that the column for tags is missing. I think this is processed in https://github.com/kotakanbe/go-cve-dictionary/blob/master/fetcher/nvd/json/nvd.go#L253
tag := strings.Join(ref.TAGS, " ")
but not stored anywhere.

One approach would be to provide a pull request to modify the data models and to store the tags data seperated by ',' as is the case in the NVD provided JSON format (https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-recent.json.zip), too.

from vulncode-db.

@evonide Thanks for the research.

For the PR solution to work, #41 should be get done with.

A quick fix would be to modify vulncode-db's go-cve-dictionary fork . With some minor refactors propagating our changes to latest upstream will be easy(and then file a PR there) .

If this works for you please assign me this ticket (and expect a PR soon :) ) .

from vulncode-db.

Sounds good I'll get back once I've looked into resolving #41.

from vulncode-db.

Hey Shivam, as promised I've updated go-cve-dictionary to the latest state in #41.
Assigning to you as suggested. Please let me know if I can help with this.

from vulncode-db.

@evonide please review #45 .

Unrelated to this, but I was wondering why are their migrations for the cve database at 2 places ? There's migrations at alembic and also go-cve-dictionary creates the same schema. This creates issues when go-cve-dictionary is ran before frontend. The alembic migrations then attempt to create the same schema which was created before by go-cve-dictionary.

from vulncode-db.

Thanks and fully agreed Shivam! I'll look into how to best resolve this soon.

from vulncode-db.