Introduce event logging abstraction. about vulkan-performance-layers HOT 4 CLOSED

Thanks for writing this up!

A few comments and questions:

An EventLogger takes Event(s) as input and produces a log based on the desired format (CSV, Chrome trace event, etc).

We could say that the input is a stream or sequence of Events.

The EventLogger would be an abstract class with 2 public methods: AddEvent() and GenerateLog(). Each format implements the bodies based on its specifications.

Why do we need GenerateLog()? I'd think that it can generate logs when it decides to do so (e.g., with each new event, each n events, etc.) or when a flush method is called.

and this in the Chrome event trace format:
...

Is this the final format that you decided on or just an example?

Adding header/footers to generate the final log:

Ah, I think I know why you wanted to have GenerateLog(): to generate the prefix and suffix. Doesn't this force us to print the whole log at once instead of streaming the results to the output? What do you think about exposing StartLog() and FinalizeLog() instead?

from vulkan-performance-layers.

Yeah, the main reason for keeping all the events and using the GenerateLog() method was prefix and suffix. Using StartLog() and FinalizeLog() is a good idea because it moves out the job of dealing with the prefixes and suffixes to another function and the EventLogger can focus on turning the events into entries.

from vulkan-performance-layers.

@miladHakimi can we close this?

from vulkan-performance-layers.

@miladHakimi can we close this?

Sure!

from vulkan-performance-layers.