Can NetworkResponse be Parcelable? about volley HOT 4 CLOSED

master...alexchau-google:patch-1

from volley.

Serializable is generally not a wise idea on Android. It's slow and generates a ton of garbage:

https://stackoverflow.com/questions/3611843/is-using-serializable-in-android-bad

Making it Parcelable might be reasonable, but I'd need to think through whether that might have bad implications on potential existing subclasses of NetworkResponse, which is not final.

I would suggest just making your own Parcelable helper classes as you see fit in the meantime.

from volley.

Got it. Parcelable also works, our only use case is for passing around as part of Intent.

from volley.

On reflection, I think it would be best to avoid doing this in NetworkResponse itself. While in general Volley is intended to be used for small response bodies, NetworkResponse data can be somewhat large given that it contains the entire response body as a byte array and the list of all response header keys/values.

Binder is intended for transmission of very small values; it will crash your app if you try to send anything larger than even 1 MB over it (and that limit is shared over a whole process so the effective limit can be even less than this). This kind of crashing can be a bit tricky, e.g. you might be able to pass the data in an Intent and have it work, but then crash when you rotate the screen which triggers a parcel/unparcel pass.

While it can be reasonable to send this data directly if you know your requests/responses are small, I don't think we should make it easy to do that in Volley without thinking through these ramifications. Instead, I think it should be up to client apps to decide carefully what they should/shouldn't send over the parcel boundary by extracting needed information out of the NetworkResponse and only sending that. Ideally only the specific info that needs to be transferred over binder can be, or if larger transfers are needed then a more scalable approach like a ContentProvider should be used.

from volley.