Typos and why does New panic? about uuid HOT 5 CLOSED

New is often used as a global:

var instance = uuid.New()

New should never fail unless your random number generated is broken. A bad random number generator is probably worth panicing over.

from uuid.

Just came to file this same bug. I am rewriting some code to unpack over the New panic potential, and decided to detect and find errors myself. Go over to the documentation for NewRandom and the documentation says it panics, but the signature and the code itself implies that it returns an error I can manage myself.

from uuid.

First typo was addressed in 0614758

second typo is being addressed in bb91e0b

from uuid.

New() calling panic is deceptive. The developer should have control over calling Must(NewRandom()) directly (since changing New() to return an error would be a breaking change for anyone using the library to date). A New() that fails should set the UUID to all 0, and the UUID can be validated with a secondary function IsValid() or something stupid.

from uuid.

I am closing this out as I don't think this will change.

from uuid.