Git Product home page Git Product logo

Comments (2)

cgruber avatar cgruber commented on May 5, 2024

So, some things aren't worth the API weight, I think. And in this case, I think a few of them are easier to just write:

ASSERT.that(map.size()).is(10);
ASSERT.that(map.keys()).has().allOf(a, b);

but some valid assertions directly on the map seem to be:

ASSERT.that(map).hasKey("foo").withValue("bar");

This is similar to the hasField("foo").withValue("bar"); pattern used in Subject itself, and it makes sense here.

AS to the others, it's sort of cute, but I'm just not sure it's worth it. Now the same thing can be said about all subject methods, and you can represent any of these propositions with assertTrue(somePredicate) in theory, so maybe I'm being too conservative here. I just feel like it doesn't add anything, where hasKey().withValue() seems to.

Thoughts? I'll certainly start there.

from truth.

cgruber avatar cgruber commented on May 5, 2024

Initial MapSubject created and merged. Closing this. Feel free to open it or another if more features are desired on MapSubject than

hasKey()
hasKey().withValue()
lacksKey()
lacksValue()
isEmpty()
isNotEmpty()

from truth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.