Comments (5)
@tstromberg Hey! I think I am brave enough for this task. I have already started working on it. I think soon I will be ready to show you first draft PR.
from triage-party.
I don't personally use GitLab, but I would be open to open to accepting PR's that add GitLab support. I agree that it is likely to be a large endeavor to do so, and would require a motivated person to get through.
Triage Party does not make any complicated API calls to GitHub, but does lean heavily on interfaces provided by https://github.com/google/go-github (like *github.User, *github.Label). If there is a gitlab library that provides similar interfaces, it wouldn't be too difficult. If not, some adaptation would be required.
If someone is brave enough to take this on, I'm happy to help guide them. I would personally start by pulling the GitHub API calls code out of pkg/hubbub
, and move it to pkg/provider
:
- pkg/hubbub/issue.go
- pkg/hubbub/orgs.go
- pkg/hubbub/pull_request.go
.. and then replace instances of *github.User and *github.Label with a generalized struct (like provider.User
). At this point, you will be nearly out of the woods in abstracting it out, and can then add in a GitLab provider.
from triage-party.
If someone wants to take this on... one idea is:
- Add GitLab support in the
pkg/hubbub
package. It already translates GitHub objects into it's own native structs. - https://github.com/xanzy/go-gitlab seems like a reasonable.
from triage-party.
@vavilen84 - Wow. That's amazing to hear. Good luck, I know this is not going to be a trivial addition.
from triage-party.
@tstromberg Hey! My PR is ready for review #193 - I mentioned my concerns in the last PR comment. If you have ideas of what I can fix/improve/change - please, tell me.
from triage-party.
Related Issues (20)
- Investigate performance/cache regression after GitLab merge
- FR: Highlight unplanned work in Kanban dashboard HOT 1
- kanban: can't evaluate field GetClosedIssues in type *provider.Milestone HOT 1
- Issue filters aren't being applied correctly HOT 1
- Got "not existing provider" with GHE
- FR: Filtering by status HOT 1
- panic: nil dereference in GithubProvider.getResponse()
- Milestone view should default to next scheduled milestone
- FR: Scope repos to collections HOT 2
- Excluding issues by project members/contributors/collaborators HOT 3
- Add ability to include all repositories of an organization HOT 2
- Add ability to define emeritus members HOT 1
- FR: filter for multiple labels of a type
- "No cached data found" with SQL persistence
- GH Token is exposed in pod logs
- FR: Configure what columns to show in collections
- issues with multiple assignees HOT 3
- Publish docker release for `1.5.0`
- Bump jquery version to one without vulnerabilities HOT 1
- Consistent segmentation violation with pypa/pip and a minimal configuration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from triage-party.