Git Product home page Git Product logo

Comments (5)

vavilen84 avatar vavilen84 commented on July 28, 2024 2

@tstromberg Hey! I think I am brave enough for this task. I have already started working on it. I think soon I will be ready to show you first draft PR.

from triage-party.

tstromberg avatar tstromberg commented on July 28, 2024

I don't personally use GitLab, but I would be open to open to accepting PR's that add GitLab support. I agree that it is likely to be a large endeavor to do so, and would require a motivated person to get through.

Triage Party does not make any complicated API calls to GitHub, but does lean heavily on interfaces provided by https://github.com/google/go-github (like *github.User, *github.Label). If there is a gitlab library that provides similar interfaces, it wouldn't be too difficult. If not, some adaptation would be required.

If someone is brave enough to take this on, I'm happy to help guide them. I would personally start by pulling the GitHub API calls code out of pkg/hubbub, and move it to pkg/provider:

  • pkg/hubbub/issue.go
  • pkg/hubbub/orgs.go
  • pkg/hubbub/pull_request.go

.. and then replace instances of *github.User and *github.Label with a generalized struct (like provider.User). At this point, you will be nearly out of the woods in abstracting it out, and can then add in a GitLab provider.

from triage-party.

tstromberg avatar tstromberg commented on July 28, 2024

If someone wants to take this on... one idea is:

  • Add GitLab support in the pkg/hubbub package. It already translates GitHub objects into it's own native structs.
  • https://github.com/xanzy/go-gitlab seems like a reasonable.

from triage-party.

tstromberg avatar tstromberg commented on July 28, 2024

@vavilen84 - Wow. That's amazing to hear. Good luck, I know this is not going to be a trivial addition.

from triage-party.

vavilen84 avatar vavilen84 commented on July 28, 2024

@tstromberg Hey! My PR is ready for review #193 - I mentioned my concerns in the last PR comment. If you have ideas of what I can fix/improve/change - please, tell me.

from triage-party.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.