Add gjslint to PRESUBMIT.py about trace-viewer HOT 6 CLOSED

From [email protected] on June 19, 2012 00:34:42

Issue 43 has been merged into this issue.

Cc: [email protected]

from trace-viewer.

From [email protected] on July 17, 2012 17:42:18

Status: Started
Owner: [email protected]
Cc: [email protected] [email protected]

from trace-viewer.

From [email protected] on July 17, 2012 17:58:58

I dont suggest working on this, kass. There are complications here that I'm not sure I'm up to explaining right now. Unless you feel strongly about it.

from trace-viewer.

From [email protected] on August 23, 2012 10:19:50

Status: Available
Owner: ---

from trace-viewer.

From [email protected] on August 28, 2012 22:51:56

I've fixed the module system issues that were preventing this from happening, fixed the lint issues we've accumulated over the ages, and added a basic gjslint.py script that gets things going manually.

The final bits of the hookup are:

• adding closure_linter and python_gflags to third_party from chrome/third_party
• adding chrome/browser_resources/web_dev_style/ to third_party (and creating a README.chromium)
• hooking those checkers into PRESUBMIT.py script (using the approach in /browser/resources/PRESUBMIT.py)

Kass, any interest? Or should I do it?

from trace-viewer.

From [email protected] on August 30, 2012 17:16:00

Status: Fixed
Owner: [email protected]

from trace-viewer.