Git Product home page Git Product logo

Comments (16)

ckennelly avatar ckennelly commented on May 4, 2024 43

Not at this time

from tcmalloc.

JonKohler avatar JonKohler commented on May 4, 2024 8

Would you accept PRs for someone adding that? or just "hard no"? :)

from tcmalloc.

alexey-milovidov avatar alexey-milovidov commented on May 4, 2024 7

Some example of integration of tcmalloc to a project with CMake build system can be found here: ClickHouse/ClickHouse#11590

from tcmalloc.

ipizhenko avatar ipizhenko commented on May 4, 2024 6

+1 to this. Please publish build instructions without Bazel, using cmake or just GNU make.

from tcmalloc.

jedisct1 avatar jedisct1 commented on May 4, 2024 3

Autotools, please.

from tcmalloc.

tru avatar tru commented on May 4, 2024 2

We dropped it and went with rpmalloc instead.

from tcmalloc.

ObiWahn avatar ObiWahn commented on May 4, 2024 1

Hi, I have started to play here:

https://github.com/extcpp/tcmalloc/tree/cmake

Anybody is welcome to use the files make suggestions and create PRs. My hope is that the branch will eventually be merged into this repository. My aim is not to replace Bazel but to make tcmalloc usable for projects that use CMake and want to build tcmalloc from source. Therefore I personally neglect (tests - in the beginning) installation and especially packaging.

from tcmalloc.

ObiWahn avatar ObiWahn commented on May 4, 2024 1

cryptopp has a nice solution. I could create something similar to https://github.com/noloader/cryptopp-cmake. It would be nice if there was somebody to test and and give feedback.

UPDATE:
I have started here: https://github.com/ObiWahn/tcmalloc-cmake

from tcmalloc.

EricWF avatar EricWF commented on May 4, 2024

It's not a hard no to CMake. We've discussed it, and would like to support it in the future. However, time is a finite resource, and nobody is scheduled to work on it. I've told @ckennelly that I'll look into it in the coming weeks, but I have a lot on my plate already.

We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time.

Supporting autotools is a non-goal of the project.

from tcmalloc.

tru avatar tru commented on May 4, 2024

When you say:

We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time.

What are you referring to specifically then?

I will probably write some CMake for tcmalloc soon in any case - so if I can model it "right" from the beginning I am happy to do so.

from tcmalloc.

AsteriskZuo avatar AsteriskZuo commented on May 4, 2024

Compile failed. All day. I want to use Cmake.

from tcmalloc.

Dan-Do avatar Dan-Do commented on May 4, 2024

When you say:

We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time.

What are you referring to specifically then?

I will probably write some CMake for tcmalloc soon in any case - so if I can model it "right" from the beginning I am happy to do so.

Hello @tru
How is the status of making cmake build?

from tcmalloc.

todd-richmond avatar todd-richmond commented on May 4, 2024

a cmake PR has been made that looks promising. would be great to have a tcmalloc official release once that gets in and the core code is at a known stable point. gperftools follows this project too slowly

from tcmalloc.

matta avatar matta commented on May 4, 2024

a cmake PR has been made that looks promising.

I assume this refers to #104, just to note it to make it easier to find. Cmake support would be in line with https://opensource.google/documentation/policies/cplusplus-support.

from tcmalloc.

patty641 avatar patty641 commented on May 4, 2024

Hi @tru
Are there any updates regarding the status of Cmake Build?

from tcmalloc.

tru avatar tru commented on May 4, 2024

Hi @tru Are there any updates regarding the status of Cmake Build?

#4 (comment)

from tcmalloc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.