Issue attachments not included in bitbucket_issue_converter.py about support-tools HOT 11 OPEN

Created a clone https://code.google.com/r/gbtami-googlecode2bitbucket/
It converts attachments and updates to logs. (The code contains some PyChess 
specific labels and milestones.)

Attached is a patch (download_support.patch) created at revision 8ac29fcfa 
based on the changes from comment #1 and including the following enhancements:

- Fix the project download URL (all project URLs have the form 
https://code.google.com/p/...).
- Don't re-download an attachment if it already exists in the attachments path.
- Also unescape "&" in FixUpComment.
- Remove PyChess-specific logic.

Also attached is the example of converting an issue from Google Code to 
Bitbucket:
example_google_code.pdf = Original issue.
example_bitbucket.pdf = Bitbucket import including the changes from this patch.

One additional nice-to-have feature would be better formatting [1] in 
FixUpComment for comments that include code snippets or call stacks. The 
default Markdown formatting for these is usually quite bad, including breaking 
other Markdown syntax if the comment code brackets (`{}`) are unmatched (see 
comments #1 and #4 in the example pdf for examples of bad formatting).

Also, it should be noted that the target attachments folder (passed via 
--attachments_path=<path>) needs to be relative to the db-1.0.json file 
location and included in the zip archive uploaded in Bitbucket.

[1] 
https://bitbucket.org/tutorials/markdowndemo/overview#markdown-header-code-and-s
yntax-highlighting

Attached is an updated patch with a few more minor enhancements:

- Add a space after "@" to avoid user references.
- Escape "\", "`", "_", "*" and "#" which are otherwise treated as formatting. 
This makes python and C++ call stacks look decent.
- Map "done" and "verified" statuses to "resolved".

@magreenblatt, thank you for the patches. I'll try to merge them in as soon as 
I can.

Thank for the patch. However, I get a 404 error when trying to download first 
attachement with gbtami cloned script and a "Failed to download..." message 
error with the above patch for all attachments. When directly  typing the 
address returned by the error log in a browser, the file is however accessible.

Could you tell me what I'm doing wrong and if I'm missing something to allow 
HTTP downloads from a python script (windows user here) ?

@comment#5: You'll get the "Failed to download..." error with the patch if the 
directory passed to `--attachments_path` does not already exist.

Thanks for your answer.

The directory passed as parameter exists but it seems like the patch actually 
fails if the attachment file does not exist locally.

I fixed it by removing the following line:
if not os.path.exists(path):

At this step, path contains the full pathname for the file (attachments_path/ 
attachmentId) so I'm not sure if this intended behavior or a bug.

In order to migrate attachment to github, you can use the attached patch

However, inlining images doesn't work on GitHub right now - already reported 
there.

Submitted changes to fix this to GitHub (thanks @sstrickroth). The changes for 
Bitbucket haven't been merged into the main branch, though I assume patching 
the two attached files would work to unblock users.

<a href="http://www.alrayyanclean.com/index.html">شركة تنظيف 
بالرياض</a>
<a href="http://www.alrayyanclean.com/index.html">شركة نظافة 
بالرياض</a>
<a href="http://www.alrayyanclean.com/index.html">شركات تنظيف 
بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D9%86%D
8%A7%D8%B2%D9%84.html">شركة تنظيف منازل بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D9%86%D
8%A7%D8%B2%D9%84.html">شركة نظافة منازل بالرياض</a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D9%86%D
8%A7%D8%B2%D9%84.html">شركات تنظيف منازل بالرياض</a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D9%86%D
8%A7%D8%B2%D9%84.html">شركة تنظيف شقق بالرياض</a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D9%86%D
8%A7%D8%B2%D9%84.html">شركة نظافة شقق بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D9%86%D
8%A7%D8%B2%D9%84.html">شركات تنظيف شقق بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%81%D9%84%D
9%84.html">شركة تنظيف فلل بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%81%D9%84%D
9%84.html">شركات تنظيف فلل بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D8%AE%D8%B2%D
8%A7%D9%86%D8%A7%D8%AA.html">شركة تنظيف خزانات بالرياض 
</a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D8%AE%D8%B2%D
8%A7%D9%86%D8%A7%D8%AA.html">شركات تنظيف خزانات بالرياض 
</a>
<a 
href="http://www.alrayyanclean.com/%D8%B1%D8%B4_%D9%85%D8%A8%D9%8A%D8%AF%D8%A7%D
8%AA.html">شركة رش مبيدات بالرياض</a>
<a 
href="http://www.alrayyanclean.com/%D8%B1%D8%B4_%D9%85%D8%A8%D9%8A%D8%AF%D8%A7%D
8%AA.html">شركات رش مبيدات بالرياض</a>
<a 
href="http://www.alrayyanclean.com/%D8%B1%D8%B4_%D9%85%D8%A8%D9%8A%D8%AF%D8%A7%D
8%AA.html">شركة مكافحة حشرات بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%B1%D8%B4_%D9%85%D8%A8%D9%8A%D8%AF%D8%A7%D
8%AA.html">شركات مكافحة الحشرات بالرياض</a>
<a 
href="http://www.alrayyanclean.com/%D9%83%D8%B4%D9%81_%D8%AA%D8%B3%D8%B1%D8%A8%D
8%A7%D8%AA.html">شركة كشف تسربات المياه بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AA%D9%86%D8%B8%D9%8A%D9%81_%D9%85%D8%AC%D
8%A7%D9%84%D8%B3.html">شركة تنظيف مجالس بالرياض </a>
<a 
href="http://www.alrayyanclean.com/%D8%AC%D9%84%D9%89_%D8%A8%D9%84%D8%A7%D8%B7.h
tml">شركة جلى بلاط بالرياض </a>

я не знаю за  какой вопрос голосовать, 
однако  мне кажиться не совсем правильна
пользуется космокомпьютернаятехнология 
кто из вас  знает разработки некоего кларка
о радио обхвате земного шара или ноосфера 
пьера де шардена
их идеи это фактический форма и содержания 
вашей деятельности мы видим ваши 
разработки проигнорировал их и всё идёт на 
нет по леву толстой: " вы из топорика
разрабатываете топорище ", которая снесёт 
все   мыслимый и не мыслимые дамбы