Comments (5)
The change is probably trivial and I can probably do it myself, I just want to know if this is acceptable.
from starlark-go.
Sounds fine. The only downside is that this will bloat the serialized bytecode files, since the comments can easily double the size of the compiled program. But it should be an easy change---send me a patch and I will measure whether it has performance implications on a large benchmark I can't easily share.
(The presented "alternative" won't work because syntax is not available during execution.)
from starlark-go.
Question on this: since this got merged should the grammar.txt file be updated to reflect that an optional docstring is now supported within a Suite?
from starlark-go.
Question on this: since this got merged should the grammar.txt file be updated to reflect that an optional docstring is now supported within a Suite?
There is no change to the grammar. A string literal is an expression, and any expression is a valid statement. All that has changed is the representation of function values whose first statement is a string literal.
from starlark-go.
@alandonovan - thx for clarifying.
from starlark-go.
Related Issues (20)
- Add quit() or exit() functions HOT 3
- `dir()` for current environment? HOT 5
- Anyway to check if a variable or functions exists in current environment? HOT 1
- Bug: incorrect `len()` for UTF-8 Chars HOT 1
- about reassignment limit
- Pass by value, or pass by reference? HOT 1
- s390x precision seems to be a little bit off in some operations HOT 3
- FR: Support More Methods for type `set` HOT 7
- Incomplete print() format, lack support of "%.02f" HOT 2
- Question about Security, Stack Overflows, and Runtime Panics when Running Custom Starlark Code HOT 1
- Bug in lib/time: time.parse_time can't support format like Python HOT 3
- Feature Request: Official Lib for `re`/`regex` HOT 1
- Caching Syntax Parsing Results for Scripts Run Repeatedly HOT 1
- Enhancement Request: Official Runes Library for Unicode Substring, Length, and String Manipulation HOT 6
- Thread-Safety for Built-in Types Such as Dict, List, Set HOT 1
- unexpected global variable referenced before assignment HOT 1
- Should repeated and map proto fields by writable by default? HOT 1
- Support for `struct.proto` well-known-type HOT 1
- time: allow to inject per-module or per-thread `now()` HOT 3
- Dict: support efficient key+value iteration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starlark-go.