Git Product home page Git Product logo

Comments (5)

aarzilli avatar aarzilli commented on May 7, 2024

The change is probably trivial and I can probably do it myself, I just want to know if this is acceptable.

from starlark-go.

alandonovan avatar alandonovan commented on May 7, 2024

Sounds fine. The only downside is that this will bloat the serialized bytecode files, since the comments can easily double the size of the compiled program. But it should be an easy change---send me a patch and I will measure whether it has performance implications on a large benchmark I can't easily share.

(The presented "alternative" won't work because syntax is not available during execution.)

from starlark-go.

deckarep avatar deckarep commented on May 7, 2024

Question on this: since this got merged should the grammar.txt file be updated to reflect that an optional docstring is now supported within a Suite?

from starlark-go.

alandonovan avatar alandonovan commented on May 7, 2024

Question on this: since this got merged should the grammar.txt file be updated to reflect that an optional docstring is now supported within a Suite?

There is no change to the grammar. A string literal is an expression, and any expression is a valid statement. All that has changed is the representation of function values whose first statement is a string literal.

from starlark-go.

deckarep avatar deckarep commented on May 7, 2024

@alandonovan - thx for clarifying.

from starlark-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.