Comments (2)
jschaf
commented on May 6, 2024
Are y'all open to PRs for this? If so:
- Do you have preferred API approach? Should I aim for idiomatic Go or consistency with an existing API?
If the goal is idiomatic Go, I think the API is probably similar to url.Values: https://pkg.go.dev/net/url#Values
from sqlcommenter.
sjs994
commented on May 6, 2024
Thanks @jschaf. It would be really great to have the community contribute for this feature.
Do you have preferred API approach? Should I aim for idiomatic Go or consistency with an existing API?
We would want to go with the existing API as we need a consistent spec. It would not make sense to have database instrumentation spec change for different languages.
from sqlcommenter.
Related Issues (20)
- Allow affixing SQLCommenter comment if comment already exists in statement
- Comments are added after the semicolon will not be part of the statement
- django middleware only applies to default database connections, ignoring other databases
- Re-Review PHP integration test for any bugs related corner cases.
- FastAPI middleware breaks openapi endpoint HOT 2
- Cannot see any comments in the logs when using Java with Spring Boot and Hibernate
- Allow user to configure the location of comment
- URL encoding ambiguities
- Traces not showing with Go Implementation in Query Insights HOT 8
- Go: Incorrect specification implementation causes traceparent not to work properly
- Docs Update : Add details for Spring Hibernate applications using application.yml HOT 1
- Add SQL commenter for R2DBC
- Update otel packages for sqlcommenter-sequelize HOT 1
- Spring 6/Spring Boot 3 HOT 2
- Clarification on the specification
- Add SQL commenter for gRPC Web Services
- Feature request: spec support for using bound parameters as attribute values
- nodejs: allow specifying `application` as part of the `wrap` operation
- SQLCommenter PHP/Laravel package broken because of unpublished OpenTelemetry version HOT 1
- Sqlcommenter for .NET
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlcommenter.