Indirect null checks of fields about simplecfg HOT 2 OPEN

This test case does not use the @Nullable annotation, also the NullableDereference analyzer should only analyse parameters, not fields.

Tests for nullness in other methods are not handled right now. One idea I had was to skip analysing a parameter after it has been passed to any other method, due to not knowing if that is equivalent to a null check on the parameter. I could implement that idea to reduce the number of false positives, but it would also reduce the number of true positives.

from simplecfg.

Sorry I missed an important part of this code pattern. Here is an updated version:

class A {
protected final Object obj;
public A(@nullable Object obj) {
this.obj = obj;
if (test()) {
obj.m();
}
}
boolean test() {
return obj != null;
}
}

A nullness check of called methods with parameters would not solve this problem. This also requires alias analysis.

With regard to handling of checks in methods. I would prefer fewer false positives, rather than fewer true positives. I want to avoid having the same developers seeing the same faulty warning over and over and potentially find it very annoying.

from simplecfg.