Git Product home page Git Product logo

Comments (6)

tomayac avatar tomayac commented on May 2, 2024 1

Twitter currently might just register a service worker for its mobile site, not the desktop site, which probably is the reason why you're not seeing the icon pop up.

If you try with a simple PWA like @PaulKinlan's Airhorner, you can see it works fine on Firefox as well as Waterfox:

screen shot 2018-05-23 at 15 36 59
screen shot 2018-05-23 at 15 40 54

This is working as intended, closing the issue.

from service-worker-detector.

tomayac avatar tomayac commented on May 2, 2024 1

is the extension designed to surface the icon only whilst a registered Service Worker is also active?

@grahamperrin Correct, the extension only triggers when navigator.serviceWorker.controller is no longer null, i.e., as soon as the service worker becomes active (documentation).

from service-worker-detector.

grahamperrin avatar grahamperrin commented on May 2, 2024

Interestingly, in Waterfox I got this for a domain where pages do not load when expected:

2018-05-20 19 53 35

(The non-appearance of page content is neither an issue with this extension nor, AFAICT, an issue with Waterfox.)

Two frames from a subsequent screen recording:

2018-05-20 19 55 17 frame a

2018-05-20 19 55 17 frame b

… so maybe the issue, at least for Waterfox, is that an expected preference is both:

  1. not enabled by default; and
  2. not easily accessible (no GUI) until after a different preference causes appearance of the page icon button.

(Does that make sense?)

Postscript

I imagined, wrongly, that the checkboxes would (a) be persistent; and (b) determine when the construction worker icon should surface.

Eventually I realised that the checkboxes are non-persistent, to temporarily highlight relevant strings in the pop-up.

OT from Service Worker Detector, https://github.com/MrAlex94/Waterfox/issues/581 is 'Corrupted Content Error' or 'Cannot load app' …

from service-worker-detector.

grahamperrin avatar grahamperrin commented on May 2, 2024

@tomayac thanks for the speedy feedback, and example 👍

Here, Service Worker Detector 2.3.14 added to a clean profile with Firefox 60.0.1 (64-bit) on FreeBSD-CURRENT:

2018-05-24 05 16 08 the air horner - mozilla firefox

Please, am I missing something?

I'll test on a Mac …

Postscript

After a while, but (unless I'm losing my mind) not after a reload of the page, the construction worker did appear.

I'll aim to make the issue, the non-appearance, more reproducible.

from service-worker-detector.

grahamperrin avatar grahamperrin commented on May 2, 2024

Twitter

Twitter currently might just register a service worker for its mobile site, not the desktop site, which probably is the reason why you're not seeing the icon pop up.

Here, with the same fairly clean profile (visibly dirtied only by the astonishing fragility of favicons) there is registration for Twitter:

2018-05-24 05 47 56 waterfox

– and the construction worker icon does not surface, from the menu, to the address bar. I'm reasonably certain of the non-surface because I can:

  1. un-register the service worker
  2. bring the https://twitter.com/ tab to the front
  3. click the Page actions menu icon
  4. observe the 'No active Service Worker found.' state
  5. continue observing that state whilst repeatedly using Control-R to reload the page.

Please: is the extension designed to surface the icon only whilst a registered Service Worker is also active?

from service-worker-detector.

grahamperrin avatar grahamperrin commented on May 2, 2024

OK, thanks!

Sorry for the over-focus on the Service Worker with scope https://twitter.com/. I can't guess when it will be activated …

… the Service Worker with scope https://mobile.twitter.com/ does activate, here, with a simple logged in visit to https://mobile.twitter.com/home – I have the construction worker icon in the address bar of Waterfox.


I'll ignore the non- (or delayed) activation of the worker at https://airhorner.com/ – couldn't make the oddity reproducible, in Firefox. It works in Waterfox.


I sped through all thirty-something Service Worker registrations in my main Waterfox profile.

The majority do lead to visibility of a construction worker icon. For the handful that do not, I might raise a separate issue (enhancement request), nothing too complicated …

from service-worker-detector.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.