Git Product home page Git Product logo

Comments (10)

jpoehnelt avatar jpoehnelt commented on May 5, 2024 1

@thisguychris Let me know if you still have issues and if you run into any rate limit problems. Thanks for reporting.

from secrets-sync-action.

jpoehnelt avatar jpoehnelt commented on May 5, 2024 1

Just a side question, how do you deal with potential one-offs, like if you want to sync ENV_X to only selected repositories?

I would just have another job or step in the workflow and specify the regex as ^org/repository$ for a single respository.

In my use case I have repositories named by <org>/<language>-<api>. So for example if I need to sync some JavaScript specific secrets, I have an action for all the repos with something like: ^myorg/js-.*$.

from secrets-sync-action.

thisguychris avatar thisguychris commented on May 5, 2024

@jpoehnelt nevermind seems like I was using 1.0.0, I'll open up a PR, the example was pointing to 1.0.0

from secrets-sync-action.

thisguychris avatar thisguychris commented on May 5, 2024

@jpoehnelt okay, now it doesn't find my own repo 😥. It can successfully find my org repositories, but it won't find my personal ones?

To be clear, my org has 581 repositories, and I have 191 from my account. I checked the debug statement, I'm only seeing 259 repositories from my org. the rest are from other organizations, but none where I own.

from secrets-sync-action.

jpoehnelt avatar jpoehnelt commented on May 5, 2024

I'm only seeing 259 repositories from my org. the rest are from other organizations, but none where I own.

It only lists repositories where you(or the bot token) are an owner or collaborator. It does not include if you are just a member. See https://developer.github.com/v3/repos/#list-repositories-for-the-authenticated-user. Could it be that?

from secrets-sync-action.

thisguychris avatar thisguychris commented on May 5, 2024

hi @jpoehnelt, Thank you for merging. 🤝 I apologize if I was a bit vague 🙏, what I'm saying is I am seeing repositories of my org but not under my username. So not a single repository under my username, including my dotfiles which are public is not visible, it just won't print it.

for example:
https://github.com/thisguychris/dotfiles

This repo is not listed however I write the regex under the repositories section.
I also have administrative privileges on my organization, however, I can only see half of the repositories?

Also, I haven't dig in the code, but how do you handle pagination, are you fetching on the first hundred or do you traverse to all repositories?

from secrets-sync-action.

jpoehnelt avatar jpoehnelt commented on May 5, 2024

@thisguychris see #6 for hardcoded limit. I'll remove this.

from secrets-sync-action.

github-actions avatar github-actions commented on May 5, 2024

🎉 This issue has been resolved in version 1.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from secrets-sync-action.

thisguychris avatar thisguychris commented on May 5, 2024

hey @jpoehnelt! Thank you for issuing a fix so fast. So far as with my testing, it is now able to see all my repositories on all organizations and under my username.

I'll report soon if I hit some API limits, but this is far better workflow than the one I'm using. The ability to use regex is brilliant! I could potentially re-write the repo with some suffix like -secrets or something, and I'll just run this and it'll sync. Beautiful!

Just a side question, how do you deal with potential one-offs, like if you want to sync ENV_X to only selected repositories?

from secrets-sync-action.

thisguychris avatar thisguychris commented on May 5, 2024

That's brilliant, silly me 😅. As you said, I just realize you could just have multiple jobs using the same action. Thanks for the suggestion.

from secrets-sync-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.