Database Update Failure Modes & Retry Duration about safebrowsing HOT 6 CLOSED

@colonelxc Are you the right person to bump about this?

from safebrowsing.

Hi @cpu, thanks for your message, and apologies for the latency in responding. I'm supportive of your suggestions :)

We actually have a back-off spec in our public docs that this client doesn't currently abide by. Since backend errors are rare, implementing this policy should help in getting the client back to a healthy state in a more timely fashion.

+1 for a blocking subscription channel for notifying once the client is ready.

I'm not sure how quickly we'd be able to commit these changes, but we'd be happy to review any code if you'd like to get these in sooner.

Thanks!
Alex

from safebrowsing.

Hi @cpu, thanks for your message, and apologies for the latency in responding. I'm supportive of your suggestions :)

Not a problem! Thanks for replying :-)

We actually have a back-off spec in our public docs that this client doesn't currently abide by. Since backend errors are rare, implementing this policy should help in getting the client back to a healthy state in a more timely fashion.

This seems sensible and would definitely be nicer than waiting for the next scheduled database refresh.

I'm not sure how quickly we'd be able to commit these changes, but we'd be happy to review any code if you'd like to get these in sooner.

Understood. I think for the short term we're going to stick with our existing V3 implementation and wait for the improvements we need in the V4 client library. It's unlikely I'll be able to find time in the next few sprints for a PR from our side but if we decide adopting V4 is a priority I'll revisit our engagement too.

Thanks!

from safebrowsing.

It would be nice to have this implemented asap.

Thanks for your message @alexwoz

from safebrowsing.

One half of the issues raised (the backoff behaviour) were fixed with #49. The other half will be addressed by #52 and I believe this issue should be closed after it is merged.

from safebrowsing.

I believe this issue is fully resolved now. Thanks for being patient.

from safebrowsing.